Description
Summary
When onboarding the Installer tests to Helix, one test was always failing, It_does_not_download_desktop_targeting_packs_on_unix. This test is to check that it doesn't download targeting packs on non-Windows systems. However, it doesn't work with the current design of test running based on the overlayed SDK. Instead, it does work with the 'final' build of the SDK based on the redist-installer output.
Details
When trying to figure this situation out, I produced binlogs of this test from both the SDK repo and the Install repo for this test (by doing new DotnetBuildCommand(testInstance, "-bl:build.binlog") in the test). Looking at them, I noticed that the ProcessFrameworkReferences target runs differently. The furthest I got into the investigation was that this if-else statement ran differently between the repos. In Installer, it hit the if-statement portion, but the SDK repo hits the else portion. This causes the SDK repo to add the packs for download, downloads them, and fails the test.
Without digging further, I wondered if it was because the tests run against the redist output and not the redist-installer output. If you change this line to use "redist-installer" instead, the test passes. What this means is that when we merge the "redist" and "redist-installer" process together, this test should be re-enabled.
There's clearly something with how the SDK that the tests are being ran on affects it. I looked into it a bit deeper with Jacques, looking at stuff like the SDK version being declared in global.json and what packages exist in the NuGet cache. But, it could be a number of reasons this doesn't function properly against the overlayed SDK.