Template engine tests hitting known parallelism issue in GetVisualStudioInstances

[marcpopMSFT]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=869444
Build error leg or test failing: Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_WithConditions_BasedOnFileName
Pull request: #44859

Error Message

{
  "ErrorMessage": "57005",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=869444
Error message validated: [57005]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 11/14/2024 7:41:30 PM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
1020818	dotnet/sdk	🟣 Build	Log	#48583
1020797	dotnet/sdk	🟣 Build	Log	#48028
1020389	dotnet/sdk	🟣 Run TestBuild Tests	Log	#48575
1020238	dotnet/sdk	Build	Log	#48436
2690017	dotnet-sdk	Build	Log
2689318	dotnet-sdk	Build	Log
2689420	dotnet-sdk	Run Tests in Helix	Log	#49278
2689267	dotnet-sdk	Build	Log	#49268
2689226	dotnet-sdk	Build	Log
2689019	dotnet-sdk	Build	Log	#49250
1017877	dotnet/sdk	Synchronize dotnet/dotnet (Unix)	Log	#48505
1017863	dotnet/sdk	Build	Log	#48453
1017832	dotnet/sdk	Build	Log	#48501
2688169	dotnet-sdk	Run AoT Tests	Log	#49223
1017407	dotnet/sdk	Build	Log	#48489
1017388	dotnet/sdk	Build	Log	#48477
1016953	dotnet/sdk	Build	Log	#48477
1015810	dotnet/sdk	🟣 Run FullFramework Tests	Log	#48436
1015120	dotnet/sdk	🟣 Run TestBuild Tests	Log	#48427
1013264	dotnet/sdk	Build	Log
1012936	dotnet/sdk	Run TestBuild Tests	Log	#48265
1012580	dotnet/sdk	🟣 Run TestBuild Tests	Log	#48353
1011759	dotnet/sdk	Run Tests in Helix	Log
1011448	dotnet/sdk	Synchronize dotnet/dotnet (Unix)	Log	#48327
1011167	dotnet/sdk	Build	Log	#48065
1011018	dotnet/sdk	Build	Log	#48319
1010701	dotnet/sdk	🟣 Run TestBuild Tests	Log	#48314
1009676	dotnet/sdk	Build	Log	#48267
1009612	dotnet/sdk	Build	Log	#48266
1009610	dotnet/sdk	Build	Log	#48265
1009039	dotnet/sdk	Build	Log	#48251
1008856	dotnet/sdk	Build	Log	#48244
1008753	dotnet/sdk	Build	Log	#48087
1007494	dotnet/sdk	🟣 Run TestBuild Tests	Log	#48150
1006802	dotnet/sdk	Build	Log	#48034
1006729	dotnet/sdk	Build	Log	#48087
1006492	dotnet/sdk	🟣 Run FullFramework Tests	Log	#48034
1006349	dotnet/sdk	Build	Log	#48087
1006059	dotnet/sdk	🟣 Run FullFramework Tests	Log	#48034
1006040	dotnet/sdk	Build	Log	#48087
1003945	dotnet/sdk	Build	Log	#48028
2678013	dotnet-sdk	Build	Log	#48610
2677994	dotnet-sdk	Build (cblMariner20Fpm)	Log
1002776	dotnet/sdk	🟣 Build	Log	#48085
1002266	dotnet/sdk	🟣 Build	Log	#48065
1001930	dotnet/sdk	🟣 Build	Log	#48085
1001859	dotnet/sdk	🟣 Build	Log	#48085
2676449	dotnet-sdk	🟣 Build	Log
2676416	dotnet-sdk	🟣 Build	Log
2676095	dotnet-sdk	🟣 Build	Log
998204	dotnet/sdk	🟣 Run FullFramework Tests	Log	#47898
997791	dotnet/sdk	Build	Log	#47996
997214	dotnet/sdk	Build	Log	#47985
997107	dotnet/sdk	Build	Log	#47976
996811	dotnet/sdk	Build	Log	#47898
996420	dotnet/sdk	Build	Log	#47948
995901	dotnet/sdk	Build	Log	#47945
994206	dotnet/sdk	🟣 Build	Log	#47904
993714	dotnet/sdk	Build	Log	#47875
993205	dotnet/sdk	Build	Log	#40359
991269	dotnet/sdk	Build	Log	#47792
990900	dotnet/sdk	Build	Log	#47821

Build	Definition	Test	Pull Request
1009755	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.8.WorkItemExecution	#48005
1005280	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmCompressionTests.Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmCompressionTests.Publish_WithLinkerAndCompression_IsIncremental
1002015	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.12.WorkItemExecution	#48034
1001451	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.6.WorkItemExecution	#48005
999715	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.9.WorkItemExecution	#48034
1000376	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.7.WorkItemExecution	#47994
999839	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.dll.1.WorkItemExecution	#47833
999352	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.dll.2.WorkItemExecution	#48025
999399	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.MvcBuildIntegrationTest21NetFx.Microsoft.NET.Sdk.Razor.Tests.MvcBuildIntegrationTest21NetFx.Building_Project	#48028
999316	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.12.WorkItemExecution	#47997
999041	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.10.WorkItemExecution	#48005
999073	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishASingleFileApp.Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishASingleFileApp.It_runs_single_file_apps	#47992
999021	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.9.WorkItemExecution	#47997
998949	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsCrossTargetingTests.Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsCrossTargetingTests.Build_CrosstargetingTests_CanIncludeBrowserAssets	#48016
998477	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorMultitargetIntegrationTest.Microsoft.NET.Sdk.BlazorWebAssembly.Tests.BlazorMultitargetIntegrationTest.MultiTargetApp_LoadsTheCorrectSdkBasedOnTfm	#47992
995444	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.dll.1.WorkItemExecution	#47898
995299	dotnet/sdk	Microsoft.NET.Sdk.BlazorWebAssembly.Tests.dll.1.WorkItemExecution	#47898
993731	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.dll.8.WorkItemExecution	#47833
990991	dotnet/sdk	Microsoft.DotNet.ScenarioTests.SdkTemplateTests.SdkTemplateTests.VerifyWebAppTemplate	#47833

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	19	81

[BrennanConroy]

Template engine tests hitting known parallelism issue in GetVisualStudioInstances

Is there an issue describing the problem? Are there people working on fixing it? We're hitting this in the aspnetcore repo a lot and as far as I'm aware we don't do anything with UWP which is how the sdk resolved the problem.

[baronfel]

@jaredpar sent a PR here with a short-term workaround that we're working to merge: #44930

The 'true' fix is coming in a future VS release, there was some unintended concurrent access to a critical section that wasn't locked.