Template engine tests hitting known parallelism issue in GetVisualStudioInstances

[marcpopMSFT]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=869444
Build error leg or test failing: Microsoft.DotNet.Cli.New.IntegrationTests.DotnetNewInstantiateTests.CanInstantiateTemplate_WithConditions_BasedOnFileName
Pull request: #44859

Error Message

{
  "ErrorMessage": "57005",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=869444
Error message validated: [57005]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 11/14/2024 7:41:30 PM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
1282031	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52581
1281634	dotnet/sdk	🟣 Build	Log	#52552
1281072	dotnet/sdk	Build	Log	#52846
2896017	dotnet-sdk	Run Tests in Helix	Log	#57172
2895901	dotnet-sdk	Run TestBuild Tests	Log	#57554
1280397	dotnet/sdk	🟣 Build	Log	#52677
1279984	dotnet/sdk	🟣 Build	Log	#52605
2895253	dotnet-sdk	OneLocBuild	Log
1279275	dotnet/sdk	🟣 Build	Log	#52711
1278434	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52792
1278488	dotnet/sdk	🟣 Build	Log	#50980
1277277	dotnet/sdk	Run FullFramework Tests	Log	#52667
1277203	dotnet/sdk	🟣 Build	Log	#50980
1277013	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52717
1274067	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52752
2891579	dotnet-sdk	Build	Log	#57370
1273779	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52044
1271958	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52731
1271746	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52585
1271723	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52588
2889952	dotnet-sdk	Build	Log	#57254
2889640	dotnet-sdk	Run Tests in Helix	Log	#57253
2889641	dotnet-sdk	Build	Log	#57254
1266658	dotnet/sdk	🟣 Build	Log	#52523
1266713	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52657
1268392	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52519
1268265	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52673
1267931	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52677
1266701	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52519
1266660	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52596
1265135	dotnet/sdk	Checkout dotnet/sdk@refs/pull/52583/merge to s	Log	#52583
1263919	dotnet/sdk	🟣 Build	Log	#52651
2885494	dotnet-sdk	Run Tests in Helix	Log	#56952
2884808	dotnet-sdk	Run Tests in Helix and non Helix in parallel	Log	#57077
1261135	dotnet/sdk	🟣 Build	Log	#52044
1260549	dotnet/sdk	🟣 Build	Log	#52588
1260350	dotnet/sdk	🟣 Build	Log	#52588
1260248	dotnet/sdk	🟣 Build	Log	#52583
2883625	dotnet-sdk	🟣 Build	Log
1260003	dotnet/sdk	🟣 Build	Log	#52575
1258904	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52523
2882280	dotnet-sdk	Build	Log
1257705	dotnet/sdk	Run Tests in Helix	Log	#52530
2881048	dotnet-sdk	Build	Log
1256140	dotnet/sdk	🟣 Build	Log	#52048
2880952	dotnet-sdk	Build (centosStream9)	Log	#56771
2880950	dotnet-sdk	Clone dotnet/dotnet	Log	#56771
2880951	dotnet-sdk	Build	Log	#56704
1255637	dotnet/sdk	🟣 Build	Log	#52505
1255585	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52325
2880521	dotnet-sdk	Build	Log
1255221	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52325
2880380	dotnet-sdk	Build	Log	#56695
2880379	dotnet-sdk	Build	Log	#56696
1254670	dotnet/sdk	🟣 Build	Log	#52453
1253902	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52362
2878774	dotnet-sdk	Build	Log
2878722	dotnet-sdk	Build	Log	#56375
1250984	dotnet/sdk	🟣 Run TestBuild Tests	Log	#51895
2877719	dotnet-sdk	Run Tests in Helix	Log	#56376
2877568	dotnet-sdk	🟣 Build	Log
1250743	dotnet/sdk	🟣 Build	Log	#52044
2876013	dotnet-sdk	🟣 Build	Log
1248905	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52239
1248590	dotnet/sdk	🟣 Run FullFramework Tests	Log	#52382
1248250	dotnet/sdk	Sync repo into VMR (Unix)	Log	#51765
2875423	dotnet-sdk	🟣 Build	Log
1247900	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52242
1247901	dotnet/sdk	🟣 Run TestBuild Tests	Log	#52325
2875192	dotnet-sdk	Run TestBuild Tests	Log	#56048

Build	Definition	Test	Pull Request
1281189	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1279328	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1279056	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1278482	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.7.WorkItemExecution	#52333
1277604	dotnet/sdk	Microsoft.NET.Sdk.Razor.Tests.StaticWebAssetsCrossTargetingTests.Build_CrosstargetingTests_CanIncludeBrowserAssets
1277262	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1275692	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1273026	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1271442	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1271367	dotnet/sdk	dotnet-watch.Tests.dll.1.WorkItemExecution	#52044
1270226	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1270127	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1269893	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1267740	dotnet/sdk	dotnet.Tests.dll.16.WorkItemExecution	#52664
1265019	dotnet/sdk	dotnet.Tests.dll.16.WorkItemExecution	#52664
1264061	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1264022	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52648
1263817	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52648
1263960	dotnet/sdk	Microsoft.NET.Build.Tests.dll.10.WorkItemExecution	#52583
1263835	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1262436	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
1262338	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.3.WorkItemExecution	#52596
1260599	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52596
2883700	dotnet-sdk	Microsoft.NET.ToolPack.Tests.GivenThatWeWantToPackAToolProjectWithGeneratePackageOnBuild.It_builds_successfully	#56954
1260015	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishASingleFileApp.Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishASingleFileApp.Target_after_AfterSdkPublish_executes	#52227
1257106	dotnet/sdk	dotnet.Tests.dll.23.WorkItemExecution	#52526
1253455	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.ILLink_keeps_symbols_by_default	#52242
1252852	dotnet/sdk	Microsoft.NET.Publish.Tests.dll.6.WorkItemExecution	#52242
1252698	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.ILLink_keeps_symbols_by_default	#52242
1252445	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.ILLink_keeps_symbols_by_default	#52242
1251983	dotnet/sdk	Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink2.ILLink_keeps_symbols_by_default	#52242

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	21	101

[BrennanConroy]

Template engine tests hitting known parallelism issue in GetVisualStudioInstances

Is there an issue describing the problem? Are there people working on fixing it? We're hitting this in the aspnetcore repo a lot and as far as I'm aware we don't do anything with UWP which is how the sdk resolved the problem.

[baronfel]

@jaredpar sent a PR here with a short-term workaround that we're working to merge: #44930

The 'true' fix is coming in a future VS release, there was some unintended concurrent access to a critical section that wasn't locked.

[tmat]

@baronfel @jaredpar should this issue be closed?

[baronfel]

I don't think so - the tracker is still making recent edits, which impliies it's still being hit.

[tmat]

So the fix above didn't fix it?