esproj does not have a target for pack and breaks dotnet pack

[danpowell88]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

If you add an esproj to an existing solution that has other csprojs in it and then run a dotnet pack at the solution level it will fail with XXX.esproj : error MSB4057: The target "pack" does not exist in the project.

Note you can workaround this issue by adding an empty target for pack to the esproj

<Target Name="Pack"></Target>

Expected Behavior

I can still use dotnet pack at the solution level and esproj should silently do nothing for that target

Steps To Reproduce

Create solution with csproj
Add esproj
Run dotnet pack on the solution

Exceptions (if any)

No response

.NET Version

8.0.400

Anything else?

.NET SDK:
Version: 8.0.400
Commit: 36fe6dda56
Workload version: 8.0.400-manifests.58db758f
MSBuild version: 17.11.3+0c8610977

Runtime Environment:
OS Name: Windows
OS Version: 10.0.22631
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\8.0.400\

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
[aspire]
Installation Source: SDK 8.0.400, VS 17.11.35312.102
Manifest Version: 8.2.1/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.2.1\WorkloadManifest.json
Install Type: Msi

Host:
Version: 8.0.10
Architecture: x64
Commit: 81cabf2857

.NET SDKs installed:
6.0.427 [C:\Program Files\dotnet\sdk]
8.0.110 [C:\Program Files\dotnet\sdk]
8.0.206 [C:\Program Files\dotnet\sdk]
8.0.306 [C:\Program Files\dotnet\sdk]
8.0.400 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 6.0.35 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.8 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
x86 [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
Not set

global.json file:
C:\dev\www\global.json

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

[wtgodbe]

@javiercn do you know much about how our .esproj's are supposed to work? I suspect this is an SDK issue rather than an aspnetcore issue, but wanted to check with you first

[mkArtakMSFT]

@javiercn any thoughts on this?

[javiercn]

Yep, this is an issue on the SDK, not ASP.NET and by SDK, I mean the JavaScript SDK in VS

[wtgodbe]

@joj given this is an issue w/ a VS SDK, is there a tracking issue we can dupe this against?

[joj]

We can add pack, but wouldn't it make more sense to dotnet pack to only call pack on dotnet (or otherwise known) projects? The same thing may happen with other project systems that don't have that target but exist in a solution with dotnet projects (thinking C++, for instance).

[wtgodbe]

It sounds like this is a question about dotnet pack in that case - I think we should move this to dotnet/sdk and see what they think (perhaps this has already been thought about)

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[baronfel]

cc @joj

[baronfel]

Lol, it took a second for the comments to migrate. It's possible that the solution metaproj should only invoke the Pack target on projects that have it? cc @rainersigwald. This looks like something that would impact any target that isn't part of our _defaultTargetNames.