From 12ded62bf8a6469a93c08dadbda2dc9d78aac8dd Mon Sep 17 00:00:00 2001 From: Jason Zhai Date: Wed, 16 Apr 2025 01:56:54 -0700 Subject: [PATCH 1/3] Re-enable C++/CLI tests --- .../NETCoreCppCliTest/NETCoreCppCliTest.vcxproj | 1 + .../NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj | 1 + .../NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj | 1 + 3 files changed, 3 insertions(+) diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj index 59b9407be167..b64a19c58ff1 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj @@ -42,6 +42,7 @@ true NETCoreCppCliTest 10.0 + true diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj index 48cc1d6a559b..91cceff3056b 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj @@ -42,6 +42,7 @@ true NETCoreCppCliTest 10.0 + true diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj index f12426b8f04c..532cc75bdbbf 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj @@ -42,6 +42,7 @@ true NETCoreCppCliTest 10.0 + true From 36972c6eabb35f86e570c4fea46278bab193af49 Mon Sep 17 00:00:00 2001 From: Jason Zhai Date: Wed, 16 Apr 2025 02:04:39 -0700 Subject: [PATCH 2/3] Remove Skip attribute --- ...ivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs index 128dd0ddb4c7..4808f781d25a 100644 --- a/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs +++ b/test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps.cs @@ -12,7 +12,7 @@ public GivenThatWeWantToBuildACppCliProjectWithTransitiveDeps(ITestOutputHelper private readonly Lazy _buildAsset; - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/11008")] + [FullMSBuildOnlyFact] public void It_can_generate_correct_depsJson_file() { TestAsset testAsset = _buildAsset.Value; @@ -23,7 +23,7 @@ public void It_can_generate_correct_depsJson_file() depsJsonContent.Should().Contain("NETCoreCppCliTestC.dll", "should contain transitive reference"); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/11008")] + [FullMSBuildOnlyFact] public void It_can_generate_all_runtimeconfig_files_to_output_folder() { TestAsset testAsset = _buildAsset.Value; @@ -35,7 +35,7 @@ public void It_can_generate_all_runtimeconfig_files_to_output_folder() }); } - [FullMSBuildOnlyFact(Skip = "https://github.com/dotnet/sdk/issues/11008")] + [FullMSBuildOnlyFact] public void It_can_generate_all_depsjson_files_to_output_folder() { TestAsset testAsset = _buildAsset.Value; From 5930d34399c36a99bddf1d1a4ff16405975ed928 Mon Sep 17 00:00:00 2001 From: Jason Zhai Date: Wed, 16 Apr 2025 19:25:19 -0700 Subject: [PATCH 3/3] Update project file to use VCProjectVersion 17.0 and PlatformToolset v143 for vs2022 --- .../NETCoreCppCliTest.vcxproj | 18 +++++++++--------- .../NETCoreCppCliTestB.vcxproj | 18 +++++++++--------- .../NETCoreCppCliTestC.vcxproj | 18 +++++++++--------- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj index b64a19c58ff1..d127eea82804 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTest/NETCoreCppCliTest.vcxproj @@ -35,7 +35,7 @@ - 16.0 + 17.0 {CF5DA8D7-1FDF-4E8F-AFE6-450BE16E906A} $(CurrentTargetFramework) ManagedCProj @@ -48,56 +48,56 @@ DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj index 91cceff3056b..dae8a2d10b19 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestB/NETCoreCppCliTestB.vcxproj @@ -35,7 +35,7 @@ - 16.0 + 17.0 {C8D22D0F-0C2D-4B4A-BF28-14A2D001102B} $(CurrentTargetFramework) ManagedCProj @@ -48,56 +48,56 @@ DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode diff --git a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj index 532cc75bdbbf..996c34b07d98 100644 --- a/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj +++ b/test/TestAssets/TestProjects/NetCoreCppCliLibWithTransitiveDeps/NETCoreCppCliTestC/NETCoreCppCliTestC.vcxproj @@ -35,7 +35,7 @@ - 16.0 + 17.0 {73B24404-97DE-467A-8251-6542819BCEB4} $(CurrentTargetFramework) ManagedCProj @@ -48,56 +48,56 @@ DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode DynamicLibrary true - v142 + v143 NetCore Unicode DynamicLibrary false - v142 + v143 NetCore Unicode