-
Notifications
You must be signed in to change notification settings - Fork 137
Open
Labels
area-infraSource-build infrastructure and reportingSource-build infrastructure and reporting
Description
When you enable poisoning, the VerticalManifest.xml is not getting bundled in artifacts tarball. This is caused by an msbuild target ordering issue and an property dependency.
CreatePrivateSourceBuiltArtifactsArchivedepends on theAssetManifestFilePathproperty to copy the VerticalManifest.xml - https://github.com/dotnet/dotnet/blob/5b423a447e09f11fc68720a5f78bb7c1d610b11e/eng/PublishSourceBuild.props#L129-L130AssetManifestFilePathis defined inside ofPublishToAzureDevOpsArtifactswhich is not aDependsOnTargetsforCreatePrivateSourceBuiltArtifactsArchive- https://github.com/dotnet/dotnet/blob/5b423a447e09f11fc68720a5f78bb7c1d610b11e/src/arcade/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L283-L284- In "normal" builds, PublishToAzureDevOpsArtifacts runs before
CreatePrivateSourceBuiltArtifactsArchiveso everything works. When poisoning is enabled, the order is swapped therefore the logic to copy the VerticalManifest.xml no-ops becauseAssetManifestFilePathis empty.
While this is not an issue in production today, I am concerned this could break because of the missing dependency declaration.
Metadata
Metadata
Assignees
Labels
area-infraSource-build infrastructure and reportingSource-build infrastructure and reporting
Type
Projects
Status
In Progress