Skip to content

System.CommandLine update #8702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2025
Merged

Conversation

adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Jan 28, 2025

Edit: this PR is blocked until NuGet/NuGet.Client#6236 gets merged (ETA is April).

This PR consists of #8693 and the actual changes that are required to get it to work.

dotnet-maestro bot and others added 2 commits January 23, 2025 05:01
…uild 20250122.1

System.CommandLine
 From Version 2.0.0-beta4.25071.2 -> To Version 2.0.0-beta4.25072.1
@marcpopMSFT
Copy link
Member

This needs to be coordinated with all other S.CL changes across all repos. Adding the lockdown label.

@adamsitnik adamsitnik marked this pull request as draft February 6, 2025 11:24
@adamsitnik adamsitnik changed the title System.CommandLine update [BLOCKED] System.CommandLine update Feb 6, 2025
@adamsitnik adamsitnik marked this pull request as ready for review April 14, 2025 12:05
@adamsitnik
Copy link
Member Author

@marcpopMSFT Could you please review this PR, but wait with the merge until NuGet/NuGet.Client#6236 gets merged (this week)?

@ViktorHofer ViktorHofer merged commit d92055f into dotnet:main Apr 14, 2025
10 checks passed
@ViktorHofer
Copy link
Member

I merged this in to unblock dependency flow. We can react to feedback post merge.

@marcpopMSFT
Copy link
Member

I wasn't sure if we were going to wait until the VMR was ready for multi-repo checkins for this or not. The changes look pretty straightforward. CC @MiYanni

@marcpopMSFT marcpopMSFT changed the title [BLOCKED] System.CommandLine update System.CommandLine update Apr 14, 2025
Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants