-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchored controls mis-alignment when DPI of the display is higher than 100% #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than 100%. Fixes #5774
JeremyKuhne
reviewed
Nov 4, 2021
JeremyKuhne
requested changes
Nov 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify why skipping for a 100% scale operation is needed/desired.
JeremyKuhne
approved these changes
Nov 4, 2021
@dreddy-work please raise servicing requests for 3.1, 5.0 and 6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was introduced in .NET Framework 4.7. Control
AnchorInfo
is used in the determination ofLocation
of theControl
. AnchorInfo was miscalculated (ignoredAnchorStyle
property) when controls scaled on higher DPI settings and thus location OFF as demonstrated in the linked issue. In this change, we will be checking theAnchorStyles
before overriding theAnchorInfo
.Fixes #5774
Fixes #4838
Fixes #6041
Microsoft Reviewers: Open in CodeFlow