Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchored controls mis-alignment when DPI of the display is higher than 100% #6122

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

dreddy-work
Copy link
Member

@dreddy-work dreddy-work commented Nov 4, 2021

This issue was introduced in .NET Framework 4.7. Control AnchorInfo is used in the determination of Location of the Control. AnchorInfo was miscalculated (ignored AnchorStyle property) when controls scaled on higher DPI settings and thus location OFF as demonstrated in the linked issue. In this change, we will be checking the AnchorStyles before overriding the AnchorInfo.

Fixes #5774
Fixes #4838
Fixes #6041

Microsoft Reviewers: Open in CodeFlow

@dreddy-work dreddy-work added the area-HDPI-SA Issues related to high DPI SystemAware mode label Nov 4, 2021
@dreddy-work dreddy-work requested a review from a team as a code owner November 4, 2021 20:55
@ghost ghost assigned dreddy-work Nov 4, 2021
@dreddy-work dreddy-work added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 4, 2021
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify why skipping for a 100% scale operation is needed/desired.

@ghost ghost added the waiting-author-feedback The team requires more information from the author label Nov 4, 2021
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Nov 4, 2021
@dreddy-work dreddy-work merged commit f34b861 into main Nov 5, 2021
@dreddy-work dreddy-work deleted the dev/dreddy/FixAnchorScaling branch November 5, 2021 17:11
@ghost ghost added this to the 7.0 alpha1 milestone Nov 5, 2021
@RussKie
Copy link
Member

RussKie commented Nov 5, 2021

@dreddy-work please raise servicing requests for 3.1, 5.0 and 6.0.

dreddy-work added a commit that referenced this pull request Nov 8, 2021
… than 100% (#6122)

* Fix anchored controls mis-alignment when DPI of the display is higher than 100%.

Fixes #5774
dreddy-work added a commit that referenced this pull request Nov 8, 2021
… than 100% (#6122)

* Fix anchored controls mis-alignment when DPI of the display is higher than 100%.

Fixes #5774
dreddy-work added a commit that referenced this pull request Nov 9, 2021
… than 100% (#6122)

* Fix anchored controls mis-alignment when DPI of the display is higher than 100%.

Fixes #5774
dreddy-work added a commit that referenced this pull request Nov 9, 2021
… than 100% (#6122) (#6140)

* Fix anchored controls mis-alignment when DPI of the display is higher than 100%.

Fixes #5774
@RussKie RussKie removed waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) area-HDPI-SA Issues related to high DPI SystemAware mode labels Nov 24, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants