Update anchors with Windows suggested rectangle in case of top-level window #9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
src/System.Windows.Forms/src/System/Windows/Forms/Layout/DefaultLayout.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/ContainerControl.cs
Outdated
Show resolved
Hide resolved
| @@ -1453,8 +1453,25 @@ internal void ScaleContainerForDpi(int deviceDpiNew, int deviceDpiOld, Rectangle | |||
| // events on the control. | |||
|
|
|||
| // Bounds are being scaled for the top-level window via SuggestedRectangle. We would need to skip scaling of | |||
There was a problem hiding this comment.
You still reference SuggestedRectangle in this comment
| (WINDOW_EX_STYLE)cp.ExStyle, | ||
| (uint)deviceDpiNew); | ||
| #pragma warning restore CA1416 // Validate platform compatibility | ||
| WindowsSuggestedClientRectangle = new Rectangle( |
There was a problem hiding this comment.
Consider Inflating rectangle with negative width/height - https://learn.microsoft.com/en-us/dotnet/api/system.drawing.rectangle.inflate?view=net-7.0#system-drawing-rectangle-inflate(system-int32-system-int32)
| // this control further by the 'OnFontChanged' event. | ||
| _isScaledByDpiChangedEvent = true; | ||
| // this control further by the 'OnFontChanged' event. WindowsSuggestedClientRectangle property will help in that. | ||
| WindowsSuggestedClientRectangle = suggestedRectangle; |
There was a problem hiding this comment.
There is a chance that this rectangle would not be used, i.e. there are no children to anchor. So calculation of the client rect could be delayed until needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9200.
Microsoft Reviewers: Open in CodeFlow