From 51c50d17be6b9e99f8d8795dff899cd5c01ebef7 Mon Sep 17 00:00:00 2001 From: Marc Paine Date: Fri, 26 Jun 2026 15:09:49 -0700 Subject: [PATCH] Disable AddCommitsToPR on VS insertion to avoid spurious build failures The MicroBuild Insert VS Payload task's 'Copy Commit Details to PR' feature (AddCommitsToPR) fatally fails the task *after* the insertion PR has already been created when it cannot compute a commit diff. This happened in build 3009141: the PR (DevDiv #753336) was created successfully, then the task errored with 'No changes found between 20260626.3 and 20260626.2' and exited 1. Triggers: the metadata service had no ADO bearer token, so it fell back to legacy logic and selected a canceled same-commit sibling build (20260626.3) as the diff baseline, yielding an empty diff that the plugin treats as fatal. The commits rolled into these insertions are version-number updates rather than real code changes, so the auto-generated commit list provides little value and isn't worth failing the build over. The insertion PR, reviewers, build policies and auto-complete are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- eng/pipelines/templates/steps/workload-insertion-steps.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/eng/pipelines/templates/steps/workload-insertion-steps.yml b/eng/pipelines/templates/steps/workload-insertion-steps.yml index 6c67b8eaa..deced43a0 100644 --- a/eng/pipelines/templates/steps/workload-insertion-steps.yml +++ b/eng/pipelines/templates/steps/workload-insertion-steps.yml @@ -44,7 +44,12 @@ steps: InsertionReviewers: Dotnet Core SDK and CLI InsertionBuildPolicies: Request Perf DDRITs # Documentation: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/631/Copy-Commit-Details-to-PR - AddCommitsToPR: true + # Disabled: this feature's "Copy Commit Details to PR" step fatally fails the task *after* the insertion PR + # is already created when it cannot compute a commit diff (e.g. the metadata service has no bearer token and + # the legacy fallback selects a same-commit sibling build as the baseline, yielding "No changes found"). + # The commits for these insertions are version-number updates rather than meaningful code changes, so the + # auto-generated commit list adds little value and isn't worth failing the build over. + AddCommitsToPR: false # Documentation: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/634/Link-Work-Items-to-PR LinkWorkItemsToPR: false # Documentation: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/638/Set-AutoComplete-on-an-Insertion