Timeout on android leaves test processes running

[sbomer]

When xharness aborts a test run on android due to hitting the --timeout, it kills the adb shell am instrument process, but this doesn't cause the instrumentation process on the device to stop.

I don't know how the helix infrastructure handles this (whether it restarts the emulator per run, etc), but it seems like this could cause unreliability in our test infrastructure.

We should consider handling timeouts by also issuing an adb shell am force-stop <target-package>.

[akoeplinger]

do you have an example log? I'd have expected that we uninstall the app even in the timeout case which would kill any running processes associated with the app

[sbomer]

It's just something I noticed while exploring the xharness behavior locally. The uninstall doesn't seem to stop the running instrumentation process. My xharness output shows:

info: Attempting to remove apk 'com.example.instrumentdemo.debug.test'..
info: Successfully uninstalled com.example.instrumentdemo.debug.test
XHarness exit code: 70 (TIMED_OUT)

But adb logcat | grep <myinstrumentationname> shows it's still running (I have it in a sleep/print loop).

[akoeplinger]

Interesting. I agree we should stop the app then.

I assume it's not generally been an issue in our test infrastructure since the Android devices get rebooted due to other reasons occasionally.

FYI @kotlarmilos