Skip to content

Commit 8560346

Browse files
authored
Remove FluentAssertions (#2828)
1 parent 5d565e3 commit 8560346

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

eng/Versions.props

-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@
2020
<MoqVersion>4.18.4</MoqVersion>
2121
<AutofacVersion>4.9.4</AutofacVersion>
2222
<AutofacExtrasMoqVersion>4.3.0</AutofacExtrasMoqVersion>
23-
<FluentAssertionsVersion>6.7.0</FluentAssertionsVersion>
24-
<FluentAssertionsJsonVersion>6.1.0</FluentAssertionsJsonVersion>
2523
<PollyVersion>8.4.2</PollyVersion>
2624
<LettuceEncryptVersion>1.3.0</LettuceEncryptVersion>
2725
<PrometheusNetVersion>8.2.1</PrometheusNetVersion>

test/Kubernetes.Tests/IngressConversionTests.cs

+7-6
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
using System.Text.Json;
1010
using System.Text.Json.Serialization;
1111
using System.Threading.Tasks;
12-
using FluentAssertions.Json;
1312
using k8s;
1413
using k8s.Models;
1514
using Microsoft.Extensions.Logging;
@@ -31,9 +30,10 @@ public class IngressConversionTests
3130
{
3231
public IngressConversionTests()
3332
{
34-
JsonConvert.DefaultSettings = () => new JsonSerializerSettings() {
33+
JsonConvert.DefaultSettings = () => new JsonSerializerSettings()
34+
{
3535
NullValueHandling = NullValueHandling.Ignore,
36-
Converters = {new StringEnumConverter()}
36+
Converters = { new StringEnumConverter() }
3737
};
3838
}
3939

@@ -74,7 +74,7 @@ public async Task ParsingTests(string name)
7474
YarpParser.ConvertFromKubernetesIngress(ingressContext, configContext);
7575
}
7676
}
77-
var options = new JsonSerializerOptions { Converters = {new JsonStringEnumConverter()} };
77+
var options = new JsonSerializerOptions { Converters = { new JsonStringEnumConverter() } };
7878
VerifyClusters(JsonSerializer.Serialize(configContext.BuildClusterConfig(), options), name);
7979
VerifyRoutes(JsonSerializer.Serialize(configContext.Routes, options), name);
8080
}
@@ -99,7 +99,7 @@ private static string StripNullProperties(string json)
9999
{
100100
var token = reader.TokenType;
101101
var value = reader.Value;
102-
if(reader.TokenType == JsonToken.PropertyName)
102+
if (reader.TokenType == JsonToken.PropertyName)
103103
{
104104
reader.Read();
105105
if (reader.TokenType == JsonToken.Null)
@@ -122,7 +122,8 @@ private static void VerifyJson(string json, string name, string fileName)
122122

123123
var actual = JToken.Parse(json);
124124
var jOther = JToken.Parse(other);
125-
actual.Should().BeEquivalentTo(jOther);
125+
126+
Assert.True(JToken.DeepEquals(actual, jOther), $"Expected: {jOther}\nActual: {actual}");
126127
}
127128

128129
private async Task<ICache> GetKubernetesInfo(string name, V1IngressClass ingressClass)

test/Kubernetes.Tests/Yarp.Kubernetes.Tests.csproj

-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414

1515
<ItemGroup>
1616
<PackageReference Include="Moq" Version="$(MoqVersion)" />
17-
<PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVersion)" />
18-
<PackageReference Include="FluentAssertions.Json" Version="$(FluentAssertionsJsonVersion)" />
1917
<PackageReference Include="Polly" Version="$(PollyVersion)" />
2018
</ItemGroup>
2119

0 commit comments

Comments
 (0)