Merge pull request #245 from ryan2445/ryanh/fix-negated-mnemonic

jogibear9988 · web-flow · commit 52c3a03654d5 · 2025-11-22T06:53:20.000+01:00
[S7 v5] fix negated mnemonic bug for output addresses
diff --git a/LibNoDaveConnectionLibrary/PLCs/S7_xxx/MC7/MC7toAWL.cs b/LibNoDaveConnectionLibrary/PLCs/S7_xxx/MC7/MC7toAWL.cs
@@ -2357,7 +2357,7 @@ internal static List<FunctionBlockRow> GetAWL(int Start, int Count, int MN, byte
                             else
                                 retVal.Add(new S7FunctionBlockRow()
                                 {
-                                    Command = Mnemonic.opU[MN],
+                                    Command = Mnemonic.opUN[MN],
                                     Parameter = Mnemonic.adA[MN] + Convert.ToString(BD[pos + 1] & 0x7F) + "." +
                                          Convert.ToString(BD[pos] - 0xE0)
                                 });

Original file line number	Diff line number	Diff line change
`@@ -2357,7 +2357,7 @@ internal static List<FunctionBlockRow> GetAWL(int Start, int Count, int MN, byte`
`2357`	`2357`	`else`
`2358`	`2358`	`retVal.Add(new S7FunctionBlockRow()`
`2359`	`2359`	`{`
`2360`		`- Command = Mnemonic.opU[MN],`
	`2360`	`+ Command = Mnemonic.opUN[MN],`
`2361`	`2361`	`Parameter = Mnemonic.adA[MN] + Convert.ToString(BD[pos + 1] & 0x7F) + "." +`
`2362`	`2362`	`Convert.ToString(BD[pos] - 0xE0)`
`2363`	`2363`	`});`