Removed tablespace creation and deletion since the server container is recreated before the test runs (once per github workflow run)

Author: JaBistDuNarrisch

src/Migrator.Tests/Database/DerivedDatabaseIntegrationTestServices/OracleDatabaseIntegrationTestService.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Linq;
 using System.Text;
-using System.Text.RegularExpressions;
 using System.Threading;
 using System.Threading.Tasks;
 using DotNetProjects.Migrator.Framework.Data.Common;
@@ -19,17 +18,21 @@
 
 namespace Migrator.Tests.Database.DerivedDatabaseIntegrationTestServices;
 
-public partial class OracleDatabaseIntegrationTestService(
+
+/// <summary>
+/// We use the tablespace users since the server container is recreated before the test runs (once per github workflow run)
+/// </summary>
+/// <param name="timeProvider"></param>
+/// <param name="databaseNameService"></param>
+public class OracleDatabaseIntegrationTestService(
     TimeProvider timeProvider,
     IDatabaseNameService databaseNameService)
         : DatabaseIntegrationTestServiceBase(databaseNameService), IDatabaseIntegrationTestService
 {
-    private const string TableSpacePrefix = "TS_";
     private const string UserStringKey = "User Id";
     private const string PasswordStringKey = "Password";
     private const string ReplaceString = "RandomStringThatIsNotQuotedByTheBuilderDoNotChange";
     private readonly MappingSchema _mappingSchema = new MappingSchemaFactory().CreateOracleMappingSchema();
-    private Regex _tablespaceRegex = new("^TS_TESTS_");
 
     /// <summary>
     /// Creates an oracle database for test purposes.
@@ -109,62 +112,11 @@ await Parallel.ForEachAsync(
                 await DropDatabaseAsync(databaseInfoToBeDeleted, cancellationTokenInner);
             });
 
-        // To be on the safe side we check for table spaces used in tests that have not been deleted for any reason (possible connection issues/concurrent deletion attempts - there is
-        // no transaction for DDL in Oracle etc.).
-        var tableSpaceNames = await context.GetTable<DBADataFiles>()
-            .Select(x => x.TablespaceName)
-            .ToListAsync(cancellationToken);
-
-        var toBeDeletedTableSpaces = tableSpaceNames
-            .Where(x =>
-            {
-                var replacedTablespaceString = TableSpacePrefixRegex().Replace(x, "");
-                var creationDate = DatabaseNameService.ReadTimeStampFromString(replacedTablespaceString);
-                return creationDate.HasValue && creationDate.Value < timeProvider.GetUtcNow().Subtract(_MinTimeSpanBeforeDatabaseDeletion);
-            });
-
-        foreach (var toBeDeletedTableSpace in toBeDeletedTableSpaces)
-        {
-            var maxAttempts = 4;
-            var delayBetweenAttempts = TimeSpan.FromSeconds(1);
-
-            for (var i = 0; i < maxAttempts; i++)
-            {
-                try
-                {
-                    await context.ExecuteAsync($"DROP TABLESPACE {toBeDeletedTableSpace} INCLUDING CONTENTS AND DATAFILES", cancellationToken);
-                }
-                catch
-                {
-                    var exists = await context.GetTable<DBADataFiles>().AnyAsync(x => x.TablespaceName == toBeDeletedTableSpace, cancellationToken);
-
-                    if (!exists)
-                    {
-                        break;
-                    }
-
-                    if (i + 1 == maxAttempts)
-                    {
-                        throw;
-                    }
-
-                    await Task.Delay(delayBetweenAttempts, cancellationToken);
-
-                    delayBetweenAttempts = delayBetweenAttempts.Add(TimeSpan.FromSeconds(1));
-                }
-            }
-        }
-
-        var tableSpaceName = $"{TableSpacePrefix}{tempUserName}";
-
-        var createTablespaceSql = $"CREATE TABLESPACE {tableSpaceName}";
-        await context.ExecuteAsync(createTablespaceSql, cancellationToken: cancellationToken);
-
         var stringBuilder = new StringBuilder();
         stringBuilder.Append($"CREATE USER \"{tempUserName}\" IDENTIFIED BY \"{tempUserName}\"");
-        stringBuilder.AppendLine($"DEFAULT TABLESPACE {tableSpaceName}");
+        stringBuilder.AppendLine($"DEFAULT TABLESPACE users");
         stringBuilder.AppendLine($"TEMPORARY TABLESPACE TEMP");
-        stringBuilder.AppendLine($"QUOTA UNLIMITED ON {tableSpaceName}");
+        stringBuilder.AppendLine($"QUOTA UNLIMITED ON users");
 
         await context.ExecuteAsync(stringBuilder.ToString(), cancellationToken);
 
@@ -253,40 +205,6 @@ public override async Task DropDatabaseAsync(DatabaseInfo databaseInfo, Cancella
             }
         }
 
-        var tablespaceName = $"{TableSpacePrefix}{databaseInfo.SchemaName}";
-
-        maxAttempts = 4;
-        delayBetweenAttempts = TimeSpan.FromSeconds(1);
-
-        for (var i = 0; i < maxAttempts; i++)
-        {
-            try
-            {
-                await context.ExecuteAsync($"DROP TABLESPACE {tablespaceName} INCLUDING CONTENTS AND DATAFILES", cancellationToken);
-            }
-            catch
-            {
-                var exists = await context.GetTable<DBADataFiles>().AnyAsync(x => x.TablespaceName == tablespaceName, cancellationToken);
-
-                if (!exists)
-                {
-                    break;
-                }
-
-                if (i + 1 == maxAttempts)
-                {
-                    throw;
-                }
-
-                await Task.Delay(delayBetweenAttempts, cancellationToken);
-
-                delayBetweenAttempts = delayBetweenAttempts.Add(TimeSpan.FromSeconds(1));
-            }
-        }
-
         await context.ExecuteAsync($"PURGE RECYCLEBIN", cancellationToken);
     }
-
-    [GeneratedRegex("^TS_TESTS_")]
-    private static partial Regex TableSpacePrefixRegex();
 }