Fix remote PCAP detection logic (#564)

kayoub5 · web-flow · commit e724d86edc68 · 2025-03-02T14:37:11.000+01:00
diff --git a/SharpPcap/LibPcap/LibPcapLiveDevice.cs b/SharpPcap/LibPcap/LibPcapLiveDevice.cs
@@ -109,8 +109,11 @@ public override void Open(DeviceConfiguration configuration)
                 immediateMode = true;
             }
 
+            var remote_pcap = pcapInterface.Name.StartsWith("rpcap://") 
+                || pcapInterface.Name.StartsWith("rpcaps://")
+                || credentials != null;
             // Some configurations can only be used with pcap_create
-            var use_pcap_create = credentials == null && (short)otherModes == 0;
+            var use_pcap_create = !remote_pcap && (short)otherModes == 0;
             if (use_pcap_create)
             {
                 Handle = LibPcapSafeNativeMethods.pcap_create(

Original file line number	Diff line number	Diff line change
`@@ -109,8 +109,11 @@ public override void Open(DeviceConfiguration configuration)`
`109`	`109`	`immediateMode = true;`
`110`	`110`	`}`
`111`	`111`
	`112`	`+ var remote_pcap = pcapInterface.Name.StartsWith("rpcap://")`
	`113`	`+ \|\| pcapInterface.Name.StartsWith("rpcaps://")`
	`114`	`+ \|\| credentials != null;`
`112`	`115`	`// Some configurations can only be used with pcap_create`
`113`		`- var use_pcap_create = credentials == null && (short)otherModes == 0;`
	`116`	`+ var use_pcap_create = !remote_pcap && (short)otherModes == 0;`
`114`	`117`	`if (use_pcap_create)`
`115`	`118`	`{`
`116`	`119`	`Handle = LibPcapSafeNativeMethods.pcap_create(`