Update CI (#561)

Author: kayoub5

SharpPcap/LibPcap/LibPcapLiveDevice.cs

@@ -135,7 +135,7 @@ public override void Open(DeviceConfiguration configuration)
 
                 if (Handle.IsInvalid)
                 {
-                    var err = $"Unable to open the adapter '{Name}'. {errbuf}";
+                    var err = $"Unable to open the adapter '{Name}' using pcap_create. {errbuf}";
                     throw new PcapException(err);
                 }
                 // Those are configurations that pcap_open can handle differently
@@ -171,20 +171,20 @@ public override void Open(DeviceConfiguration configuration)
                         (short)mode,                        // flags
                         (short)configuration.ReadTimeout,   // read timeout
                         ref auth,                           // authentication
-                        out errbuf);                            // error buffer
+                        out errbuf);                        // error buffer
                 }
                 catch (TypeLoadException)
                 {
                     var reason = credentials != null ? "Remote PCAP" : "Requested DeviceModes";
-                    var err = $"Unable to open the adapter '{Name}'. {reason} not supported";
+                    var err = $"Unable to open the adapter '{Name}'. {reason} is not supported";
                     throw new PcapException(err, PcapError.PlatformNotSupported);
                 }
-            }
 
-            if (Handle.IsInvalid)
-            {
-                var err = $"Unable to open the adapter '{Name}'. {errbuf}";
-                throw new PcapException(err);
+                if (Handle.IsInvalid)
+                {
+                    var err = $"Unable to open the adapter '{Name}' using pcap_open. {errbuf}";
+                    throw new PcapException(err);
+                }
             }
 
             ConfigureIfCompatible(use_pcap_create,

Test/PcapDeviceTest.cs

@@ -126,7 +126,11 @@ public void NonCompatibleModes()
             var ex = Assert.Throws<PcapException>(() => device.Open(config));
             if (ex.Error != PcapError.PlatformNotSupported)
             {
-                Assert.That(ex.Message, Does.Contain(nameof(DeviceConfiguration.BufferSize)));
+                Assert.That(
+                    ex.Message, 
+                    Does.Contain(nameof(DeviceConfiguration.BufferSize))
+                        .Or.Contain("using pcap_open")
+                );
             }
         }
 

Test/Test.csproj

@@ -10,6 +10,7 @@ SPDX-License-Identifier: MIT
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <TargetFrameworks>net8.0</TargetFrameworks>
     <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net48</TargetFrameworks>
+    <TestTfmsInParallel>false</TestTfmsInParallel>
     <CoverletOutputFormat>opencover</CoverletOutputFormat>
   </PropertyGroup>
   <ItemGroup>

azure-pipelines.yml

@@ -19,7 +19,7 @@ pr:
 jobs:
 - job: linux
   pool:
-    vmImage: ubuntu-20.04
+    vmImage: ubuntu-24.04
   steps:
   - script: sudo -E bash scripts/install-libpcap.sh
   - script: sudo -E bash scripts/install-tap.sh
@@ -29,7 +29,7 @@ jobs:
 
 - job: macos
   pool:
-    vmImage: macOS-12
+    vmImage: macOS-14
   steps:
   - script: sudo -E bash scripts/install-libpcap.sh
   - script: sudo sysctl -w net.inet.udp.maxdgram=65535