Skip to content

Commit b819bf7

Browse files
authored
Merge pull request #209 from doug-martin/v9.7.1-rc
v9.7.1
2 parents 5edc406 + 0b21ed8 commit b819bf7

45 files changed

Lines changed: 178 additions & 241 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/go.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ jobs:
2525
steps:
2626
- name: checkout
2727
uses: actions/checkout@v1
28+
- name: Run golangci-lint
29+
uses: actions-contrib/golangci-lint@v1
2830
- name: Test
2931
env:
3032
GO_VERSION: ${{ matrix.go_version }}

HISTORY.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# v9.7.1
2+
3+
* Fix all formatting for golangci-lint
4+
* Move to golangci-lint github action
5+
16
# v9.7.0
27

38
* [ADDED] Support for sqlserver dialect [#197](https://github.com/doug-martin/goqu/issues/197),[#205](https://github.com/doug-martin/goqu/issues/205) - [@vlanse](https://github.com/vlanse)

database_example_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ func ExampleDatabase_ExecContext() {
133133
}
134134

135135
func ExampleDatabase_From() {
136-
137136
db := getDb()
138137
var names []string
139138

database_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func (dtml *dbTestMockLogger) Printf(format string, v ...interface{}) {
2424
dtml.Messages = append(dtml.Messages, fmt.Sprintf(format, v...))
2525
}
2626

27-
func (dtml *dbTestMockLogger) Reset(format string, v ...interface{}) {
27+
func (dtml *dbTestMockLogger) Reset() {
2828
dtml.Messages = dtml.Messages[0:0]
2929
}
3030

delete_dataset_example_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ func ExampleDeleteDataset_Executor_returning() {
5454
}
5555

5656
func ExampleDeleteDataset_With() {
57-
5857
sql, _, _ := goqu.Delete("test").
5958
With("check_vals(val)", goqu.From().Select(goqu.L("123"))).
6059
Where(goqu.C("val").Eq(goqu.From("check_vals").Select("val"))).

delete_dataset_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,6 @@ func (dds *deleteDatasetSuite) TestExecutor() {
449449
}
450450

451451
func (dds *deleteDatasetSuite) TestSetError() {
452-
453452
err1 := errors.New("error #1")
454453
err2 := errors.New("error #2")
455454
err3 := errors.New("error #3")

dialect/mysql/mysql_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111

1212
"github.com/doug-martin/goqu/v9"
1313
"github.com/doug-martin/goqu/v9/dialect/mysql"
14-
_ "github.com/doug-martin/goqu/v9/dialect/mysql"
1514
_ "github.com/go-sql-driver/mysql"
1615
"github.com/stretchr/testify/suite"
1716
)
@@ -388,7 +387,6 @@ func (mt *mysqlTest) TestInsertReturning() {
388387
e := entry{Int: 10, Float: 1.000000, String: "1.000000", Time: now, Bool: true, Bytes: []byte("1.000000")}
389388
_, err := ds.Insert().Rows(e).Returning(goqu.Star()).Executor().ScanStruct(&e)
390389
mt.Error(err)
391-
392390
}
393391

394392
func (mt *mysqlTest) TestUpdate() {

dialect/sqlite3/sqlite3_dialect_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,6 @@ func (sds *sqlite3DialectSuite) TestBooleanOperations() {
192192
sql, _, err = ds.Where(goqu.C("a").NotILike(regexp.MustCompile("(a|b)"))).ToSQL()
193193
sds.NoError(err)
194194
sds.Equal("SELECT * FROM `test` WHERE (`a` NOT REGEXP '(a|b)')", sql)
195-
196195
}
197196

198197
func TestDatasetAdapterSuite(t *testing.T) {

dialect/sqlite3/sqlite3_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,6 @@ func (st *sqlite3Suite) TestInsert_returning() {
397397
e := entry{Int: 10, Float: 1.000000, String: "1.000000", Time: now, Bool: true, Bytes: []byte("1.000000")}
398398
_, err := ds.Insert().Rows(e).Returning(goqu.Star()).Executor().ScanStruct(&e)
399399
st.Error(err)
400-
401400
}
402401

403402
func (st *sqlite3Suite) TestUpdate() {

docker-compose.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ services:
99
- "POSTGRES_HOST_AUTH_METHOD=trust"
1010
expose:
1111
- "5432"
12+
ports:
13+
- "5432:5432"
1214

1315
mysql:
1416
image: "mysql:${MYSQL_VERSION}"
@@ -17,6 +19,8 @@ services:
1719
- "MYSQL_ALLOW_EMPTY_PASSWORD=yes"
1820
expose:
1921
- "3306"
22+
ports:
23+
- "3306:3306"
2024

2125
sqlserver:
2226
image: "mcr.microsoft.com/mssql/server:${SQLSERVER_VERSION}"
@@ -25,6 +29,8 @@ services:
2529
- "SA_PASSWORD=qwe123QWE"
2630
expose:
2731
- "1433"
32+
ports:
33+
- "1433:1433"
2834

2935
goqu:
3036
image: "golang:${GO_VERSION}"

0 commit comments

Comments
 (0)