Fixed overlay position inside Dialog

Author: douglasjunior

library/src/main/java/io/github/douglasjunior/androidSimpleTooltip/OverlayView.java

@@ -49,10 +49,12 @@ public class OverlayView extends View {
 
     private View mAnchorView;
     private Bitmap bitmap;
+    private float offset = 0;
 
     OverlayView(Context context, View anchorView) {
         super(context);
         this.mAnchorView = anchorView;
+        this.offset = context.getResources().getDimension(mDefaultOverlayCircleOffsetRes);
     }
 
     @Override
@@ -67,10 +69,10 @@ protected void dispatchDraw(Canvas canvas) {
     }
 
     private void createWindowFrame() {
-        bitmap = Bitmap.createBitmap(getWidth(), getHeight(), Bitmap.Config.ARGB_8888);
+        bitmap = Bitmap.createBitmap(getMeasuredWidth(), getMeasuredHeight(), Bitmap.Config.ARGB_8888);
         Canvas osCanvas = new Canvas(bitmap);
 
-        RectF outerRectangle = new RectF(0, 0, getWidth(), getHeight());
+        RectF outerRectangle = new RectF(0, 0, getMeasuredWidth(), getMeasuredHeight());
 
         Paint paint = new Paint(Paint.ANTI_ALIAS_FLAG);
         paint.setColor(Color.BLACK);
@@ -81,10 +83,14 @@ private void createWindowFrame() {
         paint.setColor(Color.TRANSPARENT);
         paint.setXfermode(new PorterDuffXfermode(PorterDuff.Mode.SRC_OUT));
 
-        RectF rect = SimpleTooltipUtils.calculeRectOnScreen(mAnchorView);
-        float offset = getResources().getDimensionPixelSize(mDefaultOverlayCircleOffsetRes);
-        rect.set(rect.left - offset, rect.top - offset, rect.right + offset, rect.bottom + offset);
-        osCanvas.drawOval(rect, paint);
+        RectF anchorRecr = SimpleTooltipUtils.calculeRectInWindow(mAnchorView);
+        RectF overlayRecr = SimpleTooltipUtils.calculeRectInWindow(this);
+
+        float left = anchorRecr.left - overlayRecr.left;
+        float top = anchorRecr.top - overlayRecr.top;
+        RectF oval = new RectF(left - offset, top - offset, left + mAnchorView.getMeasuredWidth() + offset, top + mAnchorView.getMeasuredHeight() + offset);
+
+        osCanvas.drawOval(oval, paint);
     }
 
     @Override

library/src/main/java/io/github/douglasjunior/androidSimpleTooltip/SimpleTooltip.java

@@ -159,8 +159,6 @@ private void configPopupWindow() {
     public void show() {
         verifyDismissed();
 
-        createOverlay();
-
         mContentLayout.getViewTreeObserver().addOnGlobalLayoutListener(mLocationLayoutListener);
         mContentLayout.getViewTreeObserver().addOnGlobalLayoutListener(mAutoDismissLayoutListener);
 
@@ -180,7 +178,7 @@ private void verifyDismissed() {
 
     private void createOverlay() {
         mOverlay = mTransparentOverlay ? new View(mContext) : new OverlayView(mContext, mAnchorView);
-        mOverlay.setLayoutParams(new ViewGroup.LayoutParams(mRootView.getMeasuredWidth(), mRootView.getMeasuredHeight()));
+        mOverlay.setLayoutParams(new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT));
         mOverlay.setOnTouchListener(mOverlayTouchListener);
         mRootView.addView(mOverlay);
     }
@@ -363,6 +361,7 @@ public void onGlobalLayout() {
             mPopupWindow.setClippingEnabled(true);
             mPopupWindow.update((int) location.x, (int) location.y, mPopupWindow.getWidth(), mPopupWindow.getHeight());
             mPopupWindow.getContentView().requestLayout();
+            createOverlay();
         }
     };
 

library/src/main/java/io/github/douglasjunior/androidSimpleTooltip/SimpleTooltipUtils.java

@@ -49,13 +49,13 @@ private SimpleTooltipUtils() {
     public static RectF calculeRectOnScreen(View view) {
         int[] location = new int[2];
         view.getLocationOnScreen(location);
-        return new RectF(location[0], location[1], location[0] + view.getWidth(), location[1] + view.getHeight());
+        return new RectF(location[0], location[1], location[0] + view.getMeasuredWidth(), location[1] + view.getMeasuredHeight());
     }
 
     public static RectF calculeRectInWindow(View view) {
         int[] location = new int[2];
         view.getLocationInWindow(location);
-        return new RectF(location[0], location[1], location[0] + view.getWidth(), location[1] + view.getHeight());
+        return new RectF(location[0], location[1], location[0] + view.getMeasuredWidth(), location[1] + view.getMeasuredHeight());
     }
 
     public static float dpFromPx(float px) {

sample/src/main/java/io/github/douglasjunior/androidSimpleTooltip/sample/MainActivity.java

@@ -227,6 +227,7 @@ public void onClick(View v) {
                             .text(getString(R.string.btn_in_dialog))
                             .gravity(Gravity.BOTTOM)
                             .animated(true)
+                            .transparentOverlay(false)
                             .build()
                             .show();
                 }