Skip to content

Commit e32c7fa

Browse files
committed
Added extension to RCTTextInput to prevent inputAcessoryView override. #3
1 parent a88c053 commit e32c7fa

File tree

9 files changed

+360
-255
lines changed

9 files changed

+360
-255
lines changed

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ This is only for iOS, Android no needed. For Android just add `android:windowSof
2424
- React >= 16.0.0-alpha.8
2525
- iOS >= 8.0
2626

27+
## NOTES:
28+
29+
- for RN >= 0.47.0, use react-native-keyboard-manager@latest
30+
- for RN <= 0.46.4, use [email protected]
31+
2732
## Use
2833

2934
It does not need any library setup to work, just [install](#install) and go.
@@ -72,7 +77,7 @@ render() {
7277
<Modal ... >
7378
// others views
7479
<PreviousNextView style={...} >
75-
// others views and all TextInput
80+
// all TextInput
7681
</PreviousNextView>
7782
</Modal>
7883
</View>

Sample/index.ios.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ KeyboardManager.setPreventShowingBottomBlankSpace(true);
4343
KeyboardManager.setEnableAutoToolbar(true);
4444
KeyboardManager.setToolbarDoneBarButtonItemText("Close");
4545
KeyboardManager.setToolbarManageBehaviour(0);
46-
KeyboardManager.setToolbarPreviousNextButtonEnable(true);
46+
KeyboardManager.setToolbarPreviousNextButtonEnable(false);
4747
KeyboardManager.setShouldToolbarUsesTextFieldTintColor(false);
4848
KeyboardManager.setShouldShowTextFieldPlaceholder(true);
4949
KeyboardManager.setOverrideKeyboardAppearance(false);
@@ -70,7 +70,7 @@ class SampleKeyboardManager extends Component {
7070
})
7171
}
7272

73-
enableDisable(value) {
73+
onEnableDisable = (value) => {
7474
KeyboardManager.setEnable(value);
7575
this.setState({
7676
enableDisable: value
@@ -101,7 +101,8 @@ class SampleKeyboardManager extends Component {
101101
state[ref] = text;
102102
self.setState(state)
103103
}}
104-
blurOnSubmit={false}
104+
placeholder={ref}
105+
blurOnSubmit={true /* 'false' causes a react-native bug */}
105106
onSubmitEditing={nextFocus}
106107
multiline={multiline}
107108
numberOfLines={multiline ? 10 : 1}
@@ -120,7 +121,7 @@ class SampleKeyboardManager extends Component {
120121

121122
{/* To try with Modal, uncomment the two following lines. */}
122123
{/* <Modal visible={true}> */}
123-
{/* <PreviousNextView style={{ flex: 1 }}> */}
124+
<PreviousNextView style={{ flex: 1 }}>
124125

125126
{/* ScrollView is not required, but may be needed in some cases. */}
126127
<ScrollView>
@@ -129,7 +130,7 @@ class SampleKeyboardManager extends Component {
129130
<Text style={{ marginTop: 50, textAlign: "center" }}>React-Native Keyboard Manager</Text>
130131
<View style={{ marginTop: 10, flexDirection: "row", alignItems: "center" }}>
131132
<Text>Enable/Disable </Text>
132-
<Switch onValueChange={this.enableDisable.bind(this)}
133+
<Switch onValueChange={this.onEnableDisable}
133134
value={this.state.enableDisable} />
134135
</View>
135136
</View>
@@ -138,7 +139,7 @@ class SampleKeyboardManager extends Component {
138139

139140
</ScrollView>
140141

141-
{/* </PreviousNextView> */}
142+
</PreviousNextView>
142143
{/* </Modal> */}
143144

144145
</View>

Sample/install.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/bin/bash
22

3+
rm -rf ../node_modules/
34
rm -rf node_modules/
45
rm yarn.lock
56
yarn install

Sample/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@
88
},
99
"dependencies": {
1010
"react": "16.0.0-alpha.12",
11-
"react-native": "0.46.4",
11+
"react-native": "0.48.4",
1212
"react-native-keyboard-manager": "file:../"
1313
},
1414
"devDependencies": {
15-
"babel-jest": "21.0.2",
15+
"babel-jest": "21.2.0",
1616
"babel-preset-react-native": "4.0.0",
17-
"jest": "21.1.0",
17+
"jest": "21.2.1",
1818
"react-test-renderer": "16.0.0-alpha.12"
1919
},
2020
"jest": {

0 commit comments

Comments
 (0)