fix(useCombobox): controlled selectedItem extra renders (#1477)

mariusc23 · web-flow · commit c6c0af5ef465 · 2023-03-08T10:30:55.000+02:00
diff --git a/src/hooks/useCombobox/utils.js b/src/hooks/useCombobox/utils.js
@@ -105,7 +105,7 @@ function useControlledReducer(reducer, initialState, props) {
           ? props.selectedItem
           : state.selectedItem
     }
-  })
+  }, [props.selectedItem, state.selectedItem])
 
   return [getState(state, props), dispatch]
 }

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ function useControlledReducer(reducer, initialState, props) {`
`105`	`105`	`? props.selectedItem`
`106`	`106`	`: state.selectedItem`
`107`	`107`	`}`
`108`		`- })`
	`108`	`+ }, [props.selectedItem, state.selectedItem])`
`109`	`109`
`110`	`110`	`return [getState(state, props), dispatch]`
`111`	`111`	`}`