chore: improve tests more coverage (#1713)

Author: dpgaspar

flask_appbuilder/security/api.py

@@ -4,6 +4,7 @@
     API_SECURITY_ACCESS_TOKEN_KEY,
     API_SECURITY_PROVIDER_DB,
     API_SECURITY_PROVIDER_LDAP,
+    API_SECURITY_REFRESH_TOKEN_KEY,
     API_SECURITY_VERSION,
 )
 from flask_appbuilder.security.schemas import login_post
@@ -107,8 +108,10 @@ def login(self) -> Response:
         resp[API_SECURITY_ACCESS_TOKEN_KEY] = create_access_token(
             identity=user.id, fresh=True
         )
-        if "refresh" in login_payload:
-            login_payload["refresh"] = create_refresh_token(identity=user.id)
+        if "refresh" in login_payload and login_payload["refresh"]:
+            resp[API_SECURITY_REFRESH_TOKEN_KEY] = create_refresh_token(
+                identity=user.id
+            )
         return self.response(200, **resp)
 
     @expose("/refresh", methods=["POST"])

flask_appbuilder/security/schemas.py

@@ -15,9 +15,7 @@
 
 
 def validate_password(value: Union[bytes, bytearray, str]) -> None:
-    if not value:
-        raise ValidationError("Password is required")
-    if len(value) == 1 and value.encode()[0] == 0:
+    if value and sum(value.encode()) == 0:
         raise ValidationError("Password null is not allowed")
 
 
@@ -31,7 +29,7 @@ def validate_provider(value: Union[bytes, bytearray, str]) -> None:
 class LoginPost(Schema):
     username = fields.String(required=True, allow_none=False, validate=Length(min=1))
     password = fields.String(
-        validate=validate_password, required=True, allow_none=False
+        validate=[Length(min=1), validate_password], required=True, allow_none=False
     )
     provider = fields.String(
         validate=[

flask_appbuilder/tests/base.py

@@ -8,6 +8,7 @@
 from flask_appbuilder.const import (
     API_SECURITY_PASSWORD_KEY,
     API_SECURITY_PROVIDER_KEY,
+    API_SECURITY_REFRESH_KEY,
     API_SECURITY_USERNAME_KEY,
     API_SECURITY_VERSION,
 )
@@ -36,7 +37,7 @@ def auth_client_post(client, token, uri, json):
         )
 
     @staticmethod
-    def _login(client, username, password):
+    def _login(client, username, password, refresh: bool = False):
         """
             Login help method
         :param client: Flask test client
@@ -45,15 +46,13 @@ def _login(client, username, password):
         :return: Flask client response class
         """
         return client.post(
-            "api/{}/security/login".format(API_SECURITY_VERSION),
-            data=json.dumps(
-                {
-                    API_SECURITY_USERNAME_KEY: username,
-                    API_SECURITY_PASSWORD_KEY: password,
-                    API_SECURITY_PROVIDER_KEY: "db",
-                }
-            ),
-            content_type="application/json",
+            f"api/{API_SECURITY_VERSION}/security/login",
+            json={
+                API_SECURITY_USERNAME_KEY: username,
+                API_SECURITY_PASSWORD_KEY: password,
+                API_SECURITY_PROVIDER_KEY: "db",
+                API_SECURITY_REFRESH_KEY: refresh,
+            },
         )
 
     def login(self, client, username, password):