chore: modernize CI and add npm install option to README#28
Open
dsherret wants to merge 7 commits into
Open
Conversation
- Replace deprecated `::set-output` with `$GITHUB_OUTPUT` in ci.yml - Bump release.yml to use jsr:@dprint/automation@0.10.3/tasks/publish-release - Add `dprint add npm:@dprint/biome` install option in README
Previously update.ts only updated the biome tag in Cargo.toml. When biome bumps its declared rust-toolchain (e.g. across 2.x), CI would silently end up trying to compile newer biome on the old toolchain. Match what dprint-plugin-ruff already does: fetch biome's rust-toolchain.toml at the new tag and bump our local channel to match (only ever upgrading; never downgrading).
rust-toolchain.toml channels may be just "1.84" (no patch); pad to MAJOR.MINOR.PATCH so @std/semver can parse it.
Aligns with how dprint-plugin-ruff's update.ts already calls raw.githubusercontent.com. The 404 branch here uses `.noThrow()` so the 404 still falls through to "upstream has no rust-toolchain.toml" rather than throwing.
…d-readme # Conflicts: # scripts/update.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::set-outputwith$GITHUB_OUTPUTinci.yml.release.ymlto usejsr:@dprint/automation@0.10.3/tasks/publish-release(from the olderraw.githubusercontent.com/dprint/automation/0.10.0/...URL).dprint add npm:@dprint/biometo the README install instructions alongside the existingdprint add biome.Test plan