fix: replace true by :

Calling the `true` command is not needed in most cases. Use the `:`
no-operation command instead.

Author: bdrung

dracut-functions.sh

@@ -648,7 +648,7 @@ get_blockdev_drv_through_sys() {
     local _path
 
     _path=$(realpath "$1")
-    while true; do
+    while :; do
         if [[ -L "$_path"/driver/module ]]; then
             _mod=$(realpath "$_path"/driver/module)
             _mod=$(basename "$_mod")
@@ -1538,7 +1538,7 @@ DRACUT_LDCONFIG=${DRACUT_LDCONFIG:-ldconfig}
 DRACUT_TESTBIN=${DRACUT_TESTBIN:-/bin/sh}
 
 if ! [[ "${DRACUT_INSTALL-}" ]]; then
-    DRACUT_INSTALL=$(find_binary dracut-install || true)
+    DRACUT_INSTALL=$(find_binary dracut-install || :)
 fi
 
 if ! [[ $DRACUT_INSTALL ]] && [[ -x "${BASH_SOURCE[0]%/*}/dracut-install" ]]; then

dracut-initramfs-restore.sh

@@ -52,7 +52,7 @@ find_initrd_for_kernel_version() {
     fi
 }
 
-mount -o ro /boot &> /dev/null || true
+mount -o ro /boot &> /dev/null || :
 
 IMG=$(find_initrd_for_kernel_version "$KERNEL_VERSION")
 if [ -z "$IMG" ]; then

dracut.sh

@@ -1086,7 +1086,7 @@ if [[ $regenerate_all == "yes" ]]; then
             [[ -f $i/modules.dep ]] || [[ -f $i/modules.dep.bin ]] || continue
             "$dracut_cmd" --kver="$i" "${dracut_args[@]}" &
         done
-        while true; do
+        while :; do
             wait -n
             wst=$?
             if [[ $wst == 127 ]]; then
@@ -1614,7 +1614,7 @@ module_check() {
     [ $# -ge 2 ] && _forced=$2
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    check() { true; }
+    check() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     _is_func check || return 0
@@ -1658,7 +1658,7 @@ module_depends() {
     [[ -z $_moddir ]] && _moddir=$(dracut_module_path "$1")
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    depends() { true; }
+    depends() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     moddir=$_moddir depends
@@ -1676,7 +1676,7 @@ module_cmdline() {
     [[ -z $_moddir ]] && _moddir=$(dracut_module_path "$1")
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    cmdline() { true; }
+    cmdline() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     moddir="$_moddir" cmdline
@@ -1694,7 +1694,7 @@ module_config() {
     [[ -z $_moddir ]] && _moddir=$(dracut_module_path "$1")
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    config() { true; }
+    config() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     moddir="$_moddir" config
@@ -1712,7 +1712,7 @@ module_install() {
     [[ -z $_moddir ]] && _moddir=$(dracut_module_path "$1")
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    install() { true; }
+    install() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     moddir="$_moddir" install
@@ -1730,7 +1730,7 @@ module_installkernel() {
     [[ -z $_moddir ]] && _moddir=$(dracut_module_path "$1")
     [[ -f $_moddir/module-setup.sh ]] || return 1
     unset "${module_functions[@]}"
-    installkernel() { true; }
+    installkernel() { :; }
     # shellcheck disable=SC1090
     . "$_moddir"/module-setup.sh
     moddir="$_moddir" installkernel

modules.d/11systemd-networkd/networkd-run.sh

@@ -15,7 +15,7 @@ for ifpath in /sys/class/net/*; do
             grep -E "^(NEXT_SERVER|ROOT_PATH)=" "$leases_file" \
                 | sed -e "s/NEXT_SERVER=/new_next_server='/" \
                     -e "s/ROOT_PATH=/new_root_path='/" \
-                    -e "s/$/'/" > "$dhcpopts_file" || true
+                    -e "s/$/'/" > "$dhcpopts_file" || :
         fi
 
         source_hook initqueue/online "$ifname"

modules.d/68lvmthinpool-monitor/start-thinpool-monitor.sh

@@ -37,7 +37,7 @@ if [ -n "$THIN_POOLS" ]; then
         lvm lvchange -ay "$THIN_POOL" --config "$CONFIG"
     done
 
-    while true; do
+    while :; do
         for THIN_POOL in $THIN_POOLS; do
             lvm lvextend --use-policies --config "$CONFIG" "$THIN_POOL"
         done

modules.d/70crypt/crypt-cleanup.sh

@@ -4,7 +4,7 @@
 rm -f -- /etc/udev/rules.d/70-luks.rules > /dev/null 2>&1
 
 if ! getarg rd.luks.uuid > /dev/null 2>&1 && getargbool 1 rd.luks > /dev/null 2>&1; then
-    while true; do
+    while :; do
         local do_break="y"
         for i in /dev/mapper/luks-*; do
             cryptsetup luksClose "$i" > /dev/null 2>&1 && do_break=n

modules.d/70lvm/lvm_scan.sh

@@ -65,7 +65,7 @@ no_lvm_conf_filter() {
     fi
 
     # /etc/lvm/lvm.conf exists with no filter setting
-    true > /run/lvm/initrd_no_filter
+    : > /run/lvm/initrd_no_filter
     return 0
 }
 

modules.d/71overlayfs-crypt/overlayfs-crypt-lib.sh

@@ -44,7 +44,7 @@ generate_random_password() {
 
     entropy_sources="/proc/sys/kernel/random/boot_id /proc/sys/kernel/random/uuid /dev/urandom"
 
-    stat -L /dev/* /proc/* /sys/* > "$tmpf" 2>&1 || true
+    stat -L /dev/* /proc/* /sys/* > "$tmpf" 2>&1 || :
 
     for src in $entropy_sources; do
         [ -e "$src" ] && head -c 4096 "$src" >> "$tmpf" 2> /dev/null
@@ -142,8 +142,8 @@ overlayfs_crypt_setup() {
 
     info "Setting up encrypted overlay on $dev"
 
-    modprobe -q dm_mod 2> /dev/null || true
-    modprobe -q dm_crypt 2> /dev/null || true
+    modprobe -q dm_mod 2> /dev/null || :
+    modprobe -q dm_crypt 2> /dev/null || :
 
     crypt_dev="/dev/mapper/$mapname"
 
@@ -189,7 +189,7 @@ overlayfs_crypt_setup() {
         warn "luksOpen failed on $dev"
         return 1
     fi
-    udevadm settle 2> /dev/null || true
+    udevadm settle 2> /dev/null || :
 
     info "LUKS device opened, waiting for $crypt_dev"
 

test/TEST-30-DMSQUASH/test.sh

@@ -57,7 +57,7 @@ check_autooverlay_marker() {
 # Reset root.img to single partition state for autooverlay test
 reset_overlay_partition() {
     test_marker_reset
-    sfdisk --delete "$TESTDIR"/root.img 2 2> /dev/null || true
+    sfdisk --delete "$TESTDIR"/root.img 2 2> /dev/null || :
     dd if=/dev/zero of="$TESTDIR"/root.img bs=1M seek=320 count=50 conv=notrunc status=none
     local rootPartitions
     rootPartitions=$(sfdisk -d "$TESTDIR"/root.img | grep -c 'root\.img[0-9]')

test/test-functions

@@ -18,7 +18,7 @@ DRACUT=${DRACUT-dracut}
 PKGLIBDIR=${PKGLIBDIR-$basedir}
 
 if [[ -f /etc/machine-id ]]; then
-    read -r TOKEN < /etc/machine-id || true
+    read -r TOKEN < /etc/machine-id || :
 fi
 [ -z "${TOKEN-}" ] && . /etc/os-release && TOKEN="$ID"