Skip to content

fix: remove basename calls#2433

Open
bdrung wants to merge 1 commit into
dracut-ng:mainfrom
bdrung:replace-basename
Open

fix: remove basename calls#2433
bdrung wants to merge 1 commit into
dracut-ng:mainfrom
bdrung:replace-basename

Conversation

@bdrung
Copy link
Copy Markdown
Member

@bdrung bdrung commented May 8, 2026

https://dracut-ng.github.io/dracut/developer/bash.html says that basename should not be used.

So replace the usage of basename by variable expansion instead.

Checklist

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@bdrung bdrung requested a review from a team as a code owner May 8, 2026 10:32
@github-actions github-actions Bot added modules Issue tracker for all modules url-lib Issues related to the url-lib module drm Issues related to the drm module nvmf Issues related to the nvmf module systemd-cryptsetup simpledrm labels May 8, 2026
https://dracut-ng.github.io/dracut/developer/bash.html says that
`basename` should not be used.

So replace the usage of `basename` by variable expansion instead.
@bdrung bdrung force-pushed the replace-basename branch from 66252f9 to e3364b8 Compare May 8, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drm Issues related to the drm module modules Issue tracker for all modules nvmf Issues related to the nvmf module simpledrm systemd-cryptsetup url-lib Issues related to the url-lib module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants