contrib: upgrade golangci-lint to 1.49.0

Signed-off-by: Yan Song <[email protected]>

Author: imeoer

.github/workflows/ci.yml

@@ -35,7 +35,7 @@ jobs:
             ${{ runner.os }}-go
       - name: test contrib UT
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.43.0
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.49.0
           make contrib-test
 
   smoke:
@@ -55,7 +55,7 @@ jobs:
         continue-on-error: true
       - name: Smoke Test
         run: |
-          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.43.0
+          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.49.0
           echo Cargo Home: $CARGO_HOME
           echo Running User: $(whoami)
           make docker-smoke

contrib/ctr-remote/.golangci.yml

@@ -2,8 +2,6 @@
 
 linters:
   enable:
-    - structcheck
-    - varcheck
     - staticcheck
     - unconvert
     - gofmt

contrib/docker-nydus-graphdriver/.golangci.yml

@@ -2,8 +2,6 @@
 
 linters:
   enable:
-    - structcheck
-    - varcheck
     - staticcheck
     - unconvert
     - gofmt

contrib/nydus-overlayfs/.golangci.yml

@@ -2,8 +2,6 @@
 
 linters:
   enable:
-    - structcheck
-    - varcheck
     - staticcheck
     - unconvert
     - gofmt

contrib/nydus-overlayfs/cmd/main.go

@@ -22,8 +22,8 @@ var (
 )
 
 /*
-   containerd run fuse.mount format: nydus-overlayfs overlay /tmp/ctd-volume107067851
-   -o lowerdir=/foo/lower2:/foo/lower1,upperdir=/foo/upper,workdir=/foo/work,extraoption={...},dev,suid]
+containerd run fuse.mount format: nydus-overlayfs overlay /tmp/ctd-volume107067851
+-o lowerdir=/foo/lower2:/foo/lower1,upperdir=/foo/upper,workdir=/foo/work,extraoption={...},dev,suid]
 */
 type mountArgs struct {
 	fsType  string

contrib/nydusify/.golangci.yml

@@ -2,8 +2,6 @@
 
 linters:
   enable:
-    - structcheck
-    - varcheck
     - staticcheck
     - unconvert
     - gofmt

contrib/nydusify/pkg/backend/backend.go

@@ -15,9 +15,9 @@ import (
 )
 
 // Backend transfers artifacts generated during image conversion to a backend storage such as:
-//		1. registry: complying to OCI distribution specification, push blob file
-//		   to registry and use the registry as a storage.
-//		2. oss: A object storage backend, which uses its SDK to transer blob file.
+// 1. registry: complying to OCI distribution specification, push blob file
+// to registry and use the registry as a storage.
+// 2. oss: A object storage backend, which uses its SDK to transer blob file.
 type Backend interface {
 	// TODO: Hopefully, we can pass `Layer` struct in, thus to be able to cook both
 	// file handle and file path.

contrib/nydusify/pkg/cache/cache.go

@@ -58,7 +58,7 @@ type Opt struct {
 // Here is the build cache workflow:
 // 1. Import cache records from registry;
 // 2. Check cache record using source layer ChainID before layer build,
-//    skip layer build if the cache hit;
+// skip layer build if the cache hit;
 // 3. Export new cache records to registry;
 type Cache struct {
 	opt Opt

contrib/nydusify/pkg/converter/provider/source.go

@@ -4,9 +4,9 @@
 
 // Package provider abstracts interface to adapt to different build environments,
 // the provider includes these components:
-// 	logger: output build progress for nydusify or buildkitd/buildctl;
-// 	remote: create a remote resolver, it communicates with remote registry;
-// 	source: responsible for getting image manifest, config, and mounting layer;
+// - logger: output build progress for nydusify or buildkitd/buildctl;
+// - remote: create a remote resolver, it communicates with remote registry;
+// - source: responsible for getting image manifest, config, and mounting layer;
 // Provider provides a default implementation, so we can use it in Nydusify
 // directly, but we need to implement it in buildkit or other any projects
 // which want to import nydusify package.