fix: skipped run after daylight saving turnover point

Author: CipherdevNL

src/Cron/HoursField.php

@@ -167,7 +167,7 @@ public function increment(DateTimeInterface &$date, $invert = false, $parts = nu
         if (! $invert) {
             if ($originalHour >= $target) {
                 $distance = 24 - $originalHour;
-                $date = $this->timezoneSafeModify($date, "+{$distance} hours");
+                $date = $date->modify("+{$distance} hours");
 
                 $actualDay = (int)$date->format('d');
                 $actualHour = (int)$date->format('H');
@@ -180,7 +180,7 @@ public function increment(DateTimeInterface &$date, $invert = false, $parts = nu
             }
 
             $distance = $target - $originalHour;
-            $date = $this->timezoneSafeModify($date, "+{$distance} hours");
+            $date = $date->modify("+{$distance} hours");
         } else {
             if ($originalHour <= $target) {
                 $distance = ($originalHour + 1);

tests/Cron/DaylightSavingsTest.php

@@ -209,28 +209,89 @@ public function testOffsetDecrementsPreviousRunDate(): void
         $this->assertEquals($dtExpected, $cron->getPreviousRunDate($dtCurrent, 0, false, $tz->getName()));
     }
 
-    public function testOffsetIncrementsMultipleRunDates(): void
+    public static function dayLightSavingExamples(): \Generator
     {
-        $expression = "0 1 * * 0";
-        $cron = new CronExpression($expression);
-        $tz = new \DateTimeZone("Europe/London");
+        yield 'fixed hour before turnover point' => [
+            "0 1 * * 0",
+            [
+                "2021-03-14 01:00+00:00",
+                "2021-03-21 01:00+00:00",
+                "2021-03-28 02:00+01:00",
+                "2021-04-04 01:00+01:00",
+                "2021-04-11 01:00+01:00",
+            ],
+            new \DateTimeZone("Europe/London"),
+            "2021-03-13 00:00+00:00",
+            "2021-04-12 00:00+01:00",
+        ];
 
-        $expected = [
-            $this->createDateTimeExactly("2021-03-14 01:00+00:00", $tz),
-            $this->createDateTimeExactly("2021-03-21 01:00+00:00", $tz),
-            $this->createDateTimeExactly("2021-03-28 02:00+01:00", $tz),
-            $this->createDateTimeExactly("2021-04-04 01:00+01:00", $tz),
-            $this->createDateTimeExactly("2021-04-11 01:00+01:00", $tz),
+        yield 'fixed hour after turnover point #202' => [
+            "0 10 * * *",
+            [
+                "2025-03-08 10:00-06:00",
+                "2025-03-09 10:00-05:00",
+                "2025-03-10 10:00-05:00",
+            ],
+            new \DateTimeZone("America/Chicago"),
+            "2025-03-08 09:00-06:00",
+            "2025-03-10 11:00-05:00",
         ];
 
-        $dtCurrent = $this->createDateTimeExactly("2021-03-13 00:00+00:00", $tz);
-        $actual = $cron->getMultipleRunDates(5, $dtCurrent, false, true, $tz->getName());
+        yield 'fixed hour after turnover point #154' => [
+            "30 07 * * *",
+            [
+                "2023-03-11 07:30-05:00",
+                "2023-03-12 07:30-04:00",
+                "2023-03-13 07:30-04:00",
+            ],
+            new \DateTimeZone("America/New_York"),
+            "2023-03-10 08:00-05:00",
+            "2023-03-13 08:00-04:00",
+        ];
+
+        yield 'fixed time inside the daylight transition hour' => [
+            "30 2 * * *",
+            [
+                "2025-03-08 02:30-06:00",
+                "2025-03-09 03:30-05:00",
+                "2025-03-10 02:30-05:00",
+            ],
+            new \DateTimeZone("America/Chicago"),
+            "2025-03-08 01:30-06:00",
+            "2025-03-10 11:00-05:00",
+        ];
+    }
+
+    /**
+     * @param string[] $expected
+     *
+     * @dataProvider dayLightSavingExamples
+     */
+    public function testOffsetIncrementsMultipleRunDates(
+        string $expression,
+        array $expected,
+        \DateTimeZone $tz,
+        string $currentDate,
+        string $currentInvertedDate
+    ): void {
+        $cron = new CronExpression($expression);
+
+        $expected = array_map(
+            function (string $dtString) use ($tz) {
+              return $this->createDateTimeExactly($dtString, $tz);
+            },
+            $expected
+        );
+        $total = count($expected);
+
+        $dtCurrent = $this->createDateTimeExactly($currentDate, $tz);
+        $actual = $cron->getMultipleRunDates($total, $dtCurrent, false, true, $tz->getName());
         foreach ($expected as $dtExpected) {
             $this->assertContainsEquals($dtExpected, $actual);
         }
 
-        $dtCurrent = $this->createDateTimeExactly("2021-04-12 00:00+01:00", $tz);
-        $actual = $cron->getMultipleRunDates(5, $dtCurrent, true, true, $tz->getName());
+        $dtCurrent = $this->createDateTimeExactly($currentInvertedDate, $tz);
+        $actual = $cron->getMultipleRunDates($total, $dtCurrent, true, true, $tz->getName());
         foreach ($expected as $dtExpected) {
             $this->assertContainsEquals($dtExpected, $actual);
         }
@@ -342,7 +403,6 @@ public function testOffsetDecrementsEveryOtherHour(): void
         $expected = [
             $this->createDateTimeExactly("2020-10-24 22:00+01:00", $tz),
             $this->createDateTimeExactly("2020-10-25 00:00+01:00", $tz),
-            $this->createDateTimeExactly("2020-10-25 01:00+00:00", $tz),
             $this->createDateTimeExactly("2020-10-25 02:00+00:00", $tz),
             $this->createDateTimeExactly("2020-10-25 04:00+00:00", $tz),
         ];