Claude tab: cancelled steps show [stopped] not [ok] + accurate Stop tooltip (#364)

A step cancelled mid-run by Stop was still marked '[ok]' when its tab
went idle -- the poll loop couldn't tell 'finished' from 'aborted and
discarded'. Completion now checks _stop_requested: a cancellable tab's
step is marked with the new 'stopped' status ('[stopped] ' in the plan
list, stays checked for a re-run, not counted as completed); a
non-cancellable tab (fanout) genuinely ran to completion and keeps
'[ok]'. The Stop button tooltip now describes the real behavior
(cancels the running step, discards its partial results, skips the
rest) instead of 'stop after the current step finishes'.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UKFKAEkBFgwTKh1E4oJkaQ

Author: drandyhaas

kicad_routing_plugin/claude_gui.py

@@ -525,7 +525,10 @@ def _create_ui(self):
         ctrl_sizer.Add(self.run_all_plan_btn, 0, wx.EXPAND | wx.LEFT | wx.RIGHT | wx.BOTTOM, 5)
 
         self.stop_plan_btn = wx.Button(self, label="Stop")
-        self.stop_plan_btn.SetToolTip("Stop after the currently running step finishes")
+        self.stop_plan_btn.SetToolTip(
+            "Cancel the currently running step (it aborts at its next safe "
+            "point and its partial results are discarded) and stop the plan; "
+            "remaining steps are not run")
         self.stop_plan_btn.Bind(wx.EVT_BUTTON, self._on_stop_plan)
         self.stop_plan_btn.Disable()
         ctrl_sizer.Add(self.stop_plan_btn, 0, wx.EXPAND | wx.LEFT | wx.RIGHT | wx.BOTTOM, 5)
@@ -981,9 +984,11 @@ def _on_plan_step_status(self, index, status):
         if not self:
             return
         from .claude_plan import step_label
-        mark = {"running": "> ", "done": "[ok] ", "failed": "[FAIL] "}[status]
+        mark = {"running": "> ", "done": "[ok] ", "failed": "[FAIL] ",
+                "stopped": "[stopped] "}[status]
         self.plan_list.SetString(index, mark + step_label(index + 1, self._plan_steps[index]))
         if status == "done":
+            # Stopped/failed steps stay checked so a re-run picks them up.
             self.plan_list.Check(index, False)
 
     def _on_plan_finished(self, completed, aborted_reason):

kicad_routing_plugin/claude_plan.py

@@ -599,7 +599,9 @@ class PlanExecutor:
     until the operation finishes. Stops on the first failed step.
 
     Callbacks (all on the main thread):
-      on_status(step_index, status)  status in 'running' | 'done' | 'failed'
+      on_status(step_index, status)
+          status in 'running' | 'done' | 'failed' | 'stopped'
+          ('stopped' = Stop cancelled the step mid-run; it did not complete)
       on_finished(completed_count, aborted_reason_or_None)
     """
 
@@ -912,6 +914,19 @@ def _poll_until_idle(self, index, busy, polls, seen_busy):
             # Give it a short grace period before declaring completion.
             wx.CallLater(self.POLL_MS, self._poll_until_idle, index, busy, polls + 1, False)
             return
+        if self._stop_requested:
+            _owner = self._action_owner(self.steps[index]["action"])
+            if _owner is not None and hasattr(_owner, '_cancel_requested'):
+                # Stop was pressed while this step ran and its tab is
+                # cancellable: the engine aborted at its next safe boundary
+                # and the tab discarded the partial results, so the step did
+                # NOT complete -- mark it stopped (and leave it checked for a
+                # re-run), never "[ok]". A non-cancellable tab (fanout) ran
+                # its step to completion, so it falls through to "done".
+                self.on_status(index, "stopped")
+                self.log(f"Claude plan: step {index + 1} stopped (cancelled)")
+                self._next_step()
+                return
         self._completed += 1
         self.on_status(index, "done")
         self.log(f"Claude plan: step {index + 1} finished")