Decorating ActiveRecord::Relation makes the SQL query re-run

[jamesst20]

Draper: 4.0.4
Rails: 8.0.1

Could this behavior be avoided?

I understand if I were to do query = query.decorate then run query.map(&:id) for the first time, next calls would be fine, but should we really have to be thinking about when we are decorating vs when the query is going to be executed for the first time? It's like decorating the ActiveRecord::Relation loses the query execution.

Thank you

[Alexander-Senko]

I’m not sure it would be an easy fix with current Draper architecture. You can read my thoughts on refactoring and further developing of Draper here.

BTW, Magic Presenter handles this issue smoothly:

>> query = Coniverse::Message.all; nil
=> nil
>> query.map &:id; nil
  Coniverse::Message Load (853.4ms)  SELECT "coniverse_messages".* FROM "coniverse_messages"
=> nil
>> query.decorate.map &:id; nil
=> nil

>> query = Coniverse::Message.all; nil
=> nil
>> query.decorate.map &:id; nil
  Coniverse::Message Load (853.4ms)  SELECT "coniverse_messages".* FROM "coniverse_messages"
=> nil
>> query.decorate.map &:id; nil
=> nil
>> query.map &:id; nil
=> nil

[Alexander-Senko]

I could port all the stuff from Magic Presenter back to Draper if I see any community interest in it. Unfortunately, got no single reply to my initiative since then.