fix(core): load/unload resources for base units

Author: hexf00

packages/core/src/services/resource-loader/__tests__/resource-loader.service.spec.ts

@@ -28,8 +28,10 @@ describe('ResourceLoaderService', () => {
     let sheetAdded$: Subject<unknown>;
     let docAdded$: Subject<unknown>;
     let slideAdded$: Subject<unknown>;
+    let baseAdded$: Subject<unknown>;
     let sheetDisposed$: Subject<unknown>;
     let docDisposed$: Subject<unknown>;
+    let baseDisposed$: Subject<unknown>;
     let slideDisposed$: Subject<unknown>;
     let resourceManagerService: {
         getAllResourceHooks: ReturnType<typeof vi.fn>;
@@ -50,8 +52,10 @@ describe('ResourceLoaderService', () => {
         sheetAdded$ = new Subject();
         docAdded$ = new Subject();
         slideAdded$ = new Subject();
+        baseAdded$ = new Subject();
         sheetDisposed$ = new Subject();
         docDisposed$ = new Subject();
+        baseDisposed$ = new Subject();
         slideDisposed$ = new Subject();
         resourceManagerService = {
             getAllResourceHooks: vi.fn(() => []),
@@ -65,11 +69,13 @@ describe('ResourceLoaderService', () => {
             getTypeOfUnitAdded$: vi.fn((type) => {
                 if (type === UniverInstanceType.UNIVER_SHEET) return sheetAdded$;
                 if (type === UniverInstanceType.UNIVER_DOC) return docAdded$;
+                if (type === UniverInstanceType.UNIVER_BASE) return baseAdded$;
                 return slideAdded$;
             }),
             getTypeOfUnitDisposed$: vi.fn((type) => {
                 if (type === UniverInstanceType.UNIVER_SHEET) return sheetDisposed$;
                 if (type === UniverInstanceType.UNIVER_DOC) return docDisposed$;
+                if (type === UniverInstanceType.UNIVER_BASE) return baseDisposed$;
                 return slideDisposed$;
             }),
             getUnit: vi.fn(),
@@ -109,6 +115,19 @@ describe('ResourceLoaderService', () => {
         expect(resourceManagerService.unloadResources).toHaveBeenCalledWith('book-1', UniverInstanceType.UNIVER_SHEET);
     });
 
+    it('loads resources when a base unit is added and unloads them when disposed', () => {
+        const base = {
+            getUnitId: () => 'base-1',
+            getSnapshot: () => ({ resources: [{ name: 'base-plugin', data: '{}' }] }),
+        };
+
+        baseAdded$.next({ unit: base });
+        baseDisposed$.next(base);
+
+        expect(resourceManagerService.loadResources).toHaveBeenCalledWith('base-1', [{ name: 'base-plugin', data: '{}' }]);
+        expect(resourceManagerService.unloadResources).toHaveBeenCalledWith('base-1', UniverInstanceType.UNIVER_BASE);
+    });
+
     it('saves a unit snapshot with current plugin resources', () => {
         univerInstanceService.getUnit.mockReturnValue({
             type: UniverInstanceType.UNIVER_SHEET,

packages/core/src/services/resource-loader/resource-loader.service.ts

@@ -78,6 +78,12 @@ export class ResourceLoaderService extends Disposable implements IResourceLoader
                         });
                         break;
                     }
+                    case UniverInstanceType.UNIVER_BASE: {
+                        this._univerInstanceService.getAllUnitsForType<UnitModel<{ resources?: IResources }>>(UniverInstanceType.UNIVER_BASE).forEach((base) => {
+                            loadHookResource(hook, base.getUnitId(), base.getSnapshot().resources, 'Base');
+                        });
+                        break;
+                    }
                 }
             });
         };
@@ -109,6 +115,12 @@ export class ResourceLoaderService extends Disposable implements IResourceLoader
             })
         );
 
+        this.disposeWithMe(
+            this._univerInstanceService.getTypeOfUnitAdded$<UnitModel<{ resources?: IResources }>>(UniverInstanceType.UNIVER_BASE).subscribe((event) => {
+                const { unit: base } = event;
+                this._resourceManagerService.loadResources(base.getUnitId(), base.getSnapshot().resources);
+            })
+        );
         this.disposeWithMe(
             this._univerInstanceService.getTypeOfUnitDisposed$<Workbook>(UniverInstanceType.UNIVER_SHEET).subscribe((workbook) => {
                 this._resourceManagerService.unloadResources(workbook.getUnitId(), UniverInstanceType.UNIVER_SHEET);
@@ -120,6 +132,11 @@ export class ResourceLoaderService extends Disposable implements IResourceLoader
                 this._resourceManagerService.unloadResources(doc.getUnitId(), UniverInstanceType.UNIVER_DOC);
             })
         );
+        this.disposeWithMe(
+            this._univerInstanceService.getTypeOfUnitDisposed$<UnitModel<{ resources?: IResources }>>(UniverInstanceType.UNIVER_BASE).subscribe((base) => {
+                this._resourceManagerService.unloadResources(base.getUnitId(), UniverInstanceType.UNIVER_BASE);
+            })
+        );
         this.disposeWithMe(
             this._univerInstanceService.getTypeOfUnitDisposed$<UnitModel>(UniverInstanceType.UNIVER_SLIDE).subscribe((slide) => {
                 this._resourceManagerService.unloadResources(slide.getUnitId(), UniverInstanceType.UNIVER_SLIDE);