Skip to content

Commit 87a63dd

Browse files
committed
fix(embed): keep product ribbon titles unprefixed
1 parent 4808dc6 commit 87a63dd

5 files changed

Lines changed: 1 addition & 8 deletions

File tree

packages/embed-ui/src/components/EmbedHostToolbarMenu.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,6 @@ function mountFullscreenProductRibbon(params: {
265265
childType: params.descriptor.childType,
266266
childUnitId: params.descriptor.childUnitId,
267267
embedId: params.descriptor.embedId,
268-
menuTitlePrefix: contribution.productName,
269268
surface: 'ribbon',
270269
});
271270
if (productMenuDisposable) {
@@ -280,7 +279,6 @@ function mountFullscreenProductRibbon(params: {
280279
childUnitId: params.descriptor.childUnitId,
281280
embedId: params.descriptor.embedId,
282281
menuSchema: undefined,
283-
menuTitlePrefix: contribution.productName,
284282
});
285283
}
286284

packages/embed-ui/src/components/embed-host-toolbar-menu.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ describe('Embed fullscreen workbench', () => {
167167
container: menuContainer,
168168
childType: UniverInstanceType.UNIVER_SHEET,
169169
childUnitId: 'child-1',
170-
menuTitlePrefix: 'Sheets',
171170
surface: 'ribbon',
172171
}));
173172
expect(floatingRegistry.get).not.toHaveBeenCalled();

packages/embed-ui/src/services/embed-block-contribution-factory.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ export function createEmbedRibbonBlockContribution(options: ICreateEmbedRibbonBl
5353
childType,
5454
childUnitId,
5555
menuSchema: resolveEmbedProductRibbonMenuSchema(injector, childType, options.menuSchema),
56-
menuTitlePrefix: productName,
5756
});
5857

5958
return {

packages/embed-ui/src/services/embed-fullscreen-and-root.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ describe('embed fullscreen helpers and react roots', () => {
9696
expect(productMenus.mountMenu).toHaveBeenCalledWith(expect.objectContaining({
9797
childType: UniverInstanceType.UNIVER_SHEET,
9898
childUnitId: 'child-1',
99-
menuTitlePrefix: 'Sheets',
10099
surface: 'ribbon',
101100
}));
102101
disposable?.dispose();

packages/embed-ui/src/services/embed-product-menu-mounting.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ describe('embed product menu mounting', () => {
127127
childType: UniverInstanceType.UNIVER_SHEET,
128128
childUnitId: 'child-sheet',
129129
menuSchema: { [MenuManagerPosition.RIBBON]: { start: { title: 'Start' } } },
130-
menuTitlePrefix: 'Sheets',
131130
activeRibbonTab: 'start',
132131
toolbarOnly: true,
133132
});
@@ -156,7 +155,6 @@ describe('embed product menu mounting', () => {
156155
insert: {},
157156
},
158157
},
159-
menuTitlePrefix: 'Sheets',
160158
activeRibbonTab: 'insert',
161159
});
162160

@@ -183,7 +181,7 @@ describe('embed product menu mounting', () => {
183181

184182
const ribbonTitles: string[][] = [];
185183
ribbonService.ribbon$.subscribe((groups) => ribbonTitles.push(groups.map((group) => group.title ?? '')));
186-
expect(ribbonTitles[0]).toEqual(['Sheets - translated(Start)', 'Sheets - translated(insert)']);
184+
expect(ribbonTitles[0]).toEqual(['Start', '']);
187185
ribbonService.setCollapsedIds(['a']);
188186
ribbonService.setFakeToolbarVisible(true);
189187
ribbonService.showContextualTab('ctx', { activate: true });

0 commit comments

Comments
 (0)