Skip to content

Commit 849295b

Browse files
committed
Update documentation and remove users creation
1 parent b64290a commit 849295b

5 files changed

Lines changed: 19 additions & 57 deletions

File tree

.github/scripts/create_dbt_test_users.sh

Lines changed: 0 additions & 34 deletions
This file was deleted.

.github/scripts/create_env_file.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,7 @@ DREMIO_SOFTWARE_USERNAME=${DREMIO_SOFTWARE_USERNAME}
1313
DREMIO_SOFTWARE_PASSWORD=${DREMIO_SOFTWARE_PASSWORD}
1414
DREMIO_DATALAKE=dbt_test_source
1515
DREMIO_DATABASE=dbt_test
16-
DBT_TEST_USER_1=dbt_test_user_1
17-
DBT_TEST_USER_2=dbt_test_user_2
18-
DBT_TEST_USER_3=dbt_test_user_3
19-
DBT_TEST_ROLE_1=dbt_test_role_1
20-
DBT_TEST_ROLE_2=dbt_test_role_2
2116
DREMIO_EDITION=community
2217
EOF
2318

24-
echo ".env file created successfully."
19+
echo ".env file created successfully."

.github/workflows/ci.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,6 @@ jobs:
9393
pip install -r dev_requirements.txt
9494
pip install .
9595
96-
- name: Create dbt test users
97-
run: bash .github/scripts/create_dbt_test_users.sh
98-
9996
- name: Create dbt projects
10097
run: bash .github/scripts/create_dbt_projects.sh
10198

tests/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ To run our tests, a test environment must be set up.
1717
DBT_TEST_USER_1=dbt_test_user_1
1818
DBT_TEST_USER_2=dbt_test_user_2
1919
DBT_TEST_USER_3=dbt_test_user_3
20+
DBT_TEST_ROLE_1=dbt_test_role_1
21+
DBT_TEST_ROLE_2=dbt_test_role_2
2022
```
2123
For cloud version of Dremio:
2224
```
@@ -29,6 +31,8 @@ To run our tests, a test environment must be set up.
2931
DBT_TEST_USER_1=dbt_test_user_1
3032
DBT_TEST_USER_2=dbt_test_user_2
3133
DBT_TEST_USER_3=dbt_test_user_3
34+
DBT_TEST_ROLE_1=dbt_test_role_1
35+
DBT_TEST_ROLE_2=dbt_test_role_2
3236
```
3337
1. Create the three users listed above (dbt_test_user_1, dbt_test_user_2, dbt_test_user_3) in the Dremio instance.
3438
1. Create a bucket in Object storage with a name `dbtdremios3`

tests/hooks/test_model_hooks.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -127,13 +127,13 @@ def check_hooks(self, state, project, host, count=1):
127127

128128

129129
class TestPrePostModelHooksDremio(BaseTestPrePost):
130-
# @pytest.fixture(scope="class")
131-
# def unique_schema(self, request, prefix) -> str:
132-
# test_file = request.module.__name__
133-
# # We only want the last part of the name
134-
# test_file = test_file.split(".")[-1]
135-
# unique_schema = f"{BUCKET}.{prefix}_{test_file}"
136-
# return unique_schema
130+
@pytest.fixture(scope="class")
131+
def unique_schema(self, request, prefix) -> str:
132+
test_file = request.module.__name__
133+
# We only want the last part of the name
134+
test_file = test_file.split(".")[-1]
135+
unique_schema = f"{BUCKET}.{prefix}_{test_file}"
136+
return unique_schema
137137

138138
@pytest.fixture(scope="class")
139139
def project_config_update(self):
@@ -308,13 +308,13 @@ def models(self):
308308
class TestPrePostModelHooksOnSeedsPlusPrefixedDremio(
309309
TestPrePostModelHooksOnSeedsDremio
310310
):
311-
# @pytest.fixture(scope="class")
312-
# def unique_schema(self, request, prefix) -> str:
313-
# test_file = request.module.__name__
314-
# # We only want the last part of the name
315-
# test_file = test_file.split(".")[-1]
316-
# unique_schema = f"{BUCKET}.{prefix}_{test_file}"
317-
# return unique_schema
311+
@pytest.fixture(scope="class")
312+
def unique_schema(self, request, prefix) -> str:
313+
test_file = request.module.__name__
314+
# We only want the last part of the name
315+
test_file = test_file.split(".")[-1]
316+
unique_schema = f"{BUCKET}.{prefix}_{test_file}"
317+
return unique_schema
318318

319319
@pytest.fixture(scope="class")
320320
def project_config_update(self):

0 commit comments

Comments
 (0)