From a366d4ff3bf4b761071bb890d153b4de818342c8 Mon Sep 17 00:00:00 2001 From: Daniel Jimenez Date: Tue, 15 Jul 2025 09:19:03 -0500 Subject: [PATCH 1/6] Fix indent issue for zookeeper pod annotations --- charts/dremio_v2/templates/zookeeper.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/dremio_v2/templates/zookeeper.yaml b/charts/dremio_v2/templates/zookeeper.yaml index 4039792e..4e8dd2ee 100644 --- a/charts/dremio_v2/templates/zookeeper.yaml +++ b/charts/dremio_v2/templates/zookeeper.yaml @@ -60,7 +60,7 @@ spec: labels: app: zk {{- include "dremio.zookeeper.podLabels" $ | nindent 8 }} - {{- include "dremio.zookeeper.podAnnotations" $ | nindent 8 }} + {{- include "dremio.zookeeper.podAnnotations" $ | nindent 6 }} spec: {{- include "dremio.zookeeper.serviceAccount" $ | nindent 6 }} affinity: From 31b7ce7af4db0e0252b2e2fe563b36a2b278a0eb Mon Sep 17 00:00:00 2001 From: Daniel Jimenez Date: Tue, 15 Jul 2025 10:24:58 -0500 Subject: [PATCH 2/6] duplicate requests into limits for now --- charts/dremio_v2/templates/dremio-coordinator.yaml | 3 +++ charts/dremio_v2/templates/dremio-executor.yaml | 3 +++ charts/dremio_v2/templates/zookeeper.yaml | 3 +++ 3 files changed, 9 insertions(+) diff --git a/charts/dremio_v2/templates/dremio-coordinator.yaml b/charts/dremio_v2/templates/dremio-coordinator.yaml index eeb3e0eb..00997098 100644 --- a/charts/dremio_v2/templates/dremio-coordinator.yaml +++ b/charts/dremio_v2/templates/dremio-coordinator.yaml @@ -38,6 +38,9 @@ spec: requests: cpu: {{ $.Values.coordinator.cpu }} memory: {{ $.Values.coordinator.memory }}Mi + limits: + cpu: {{ $.Values.coordinator.cpu }} + memory: {{ $.Values.coordinator.memory }}Mi volumeMounts: - name: dremio-config mountPath: /opt/dremio/conf diff --git a/charts/dremio_v2/templates/dremio-executor.yaml b/charts/dremio_v2/templates/dremio-executor.yaml index ee440660..c019e1b9 100644 --- a/charts/dremio_v2/templates/dremio-executor.yaml +++ b/charts/dremio_v2/templates/dremio-executor.yaml @@ -42,6 +42,9 @@ spec: requests: cpu: {{ template "dremio.executor.cpu" (list $ $engineName) }} memory: "{{ template "dremio.executor.memory" (list $ $engineName) }}Mi" + limits: + cpu: {{ template "dremio.executor.cpu" (list $ $engineName) }} + memory: "{{ template "dremio.executor.memory" (list $ $engineName) }}Mi" volumeMounts: - name: {{ template "dremio.executor.volumeClaimName" (list $ $engineName) }} mountPath: /opt/dremio/data diff --git a/charts/dremio_v2/templates/zookeeper.yaml b/charts/dremio_v2/templates/zookeeper.yaml index 4e8dd2ee..9717127f 100644 --- a/charts/dremio_v2/templates/zookeeper.yaml +++ b/charts/dremio_v2/templates/zookeeper.yaml @@ -113,6 +113,9 @@ spec: requests: cpu: {{ $.Values.zookeeper.cpu }} memory: {{ $.Values.zookeeper.memory }}Mi + limits: + cpu: {{ $.Values.zookeeper.cpu }} + memory: {{ $.Values.zookeeper.memory }}Mi ports: - containerPort: 2181 name: client From e6ed3e397cac58c8c90b688920342a2ba1b6051a Mon Sep 17 00:00:00 2001 From: Daniel Jimenez Date: Tue, 15 Jul 2025 11:20:09 -0500 Subject: [PATCH 3/6] duplicate requests into limits for now --- charts/dremio_v2/templates/dremio-master.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/dremio_v2/templates/dremio-master.yaml b/charts/dremio_v2/templates/dremio-master.yaml index e25d85b5..40ecbc27 100644 --- a/charts/dremio_v2/templates/dremio-master.yaml +++ b/charts/dremio_v2/templates/dremio-master.yaml @@ -47,6 +47,9 @@ spec: requests: cpu: {{ $.Values.coordinator.cpu }} memory: {{ $.Values.coordinator.memory }}Mi + limits: + cpu: {{ $.Values.coordinator.cpu }} + memory: {{ $.Values.coordinator.memory }}Mi volumeMounts: - name: dremio-master-volume mountPath: /opt/dremio/data From 39dc6fb7fe0608c38abd15ccdd80323aa157323f Mon Sep 17 00:00:00 2001 From: Brandon <34108590+brandonaikey@users.noreply.github.com> Date: Mon, 2 Mar 2026 15:49:55 -0600 Subject: [PATCH 4/6] Update dremio-master.yaml Add `volumeClaimAnnotations` to template. --- charts/dremio_v2/templates/dremio-master.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/charts/dremio_v2/templates/dremio-master.yaml b/charts/dremio_v2/templates/dremio-master.yaml index 40ecbc27..751e03a6 100644 --- a/charts/dremio_v2/templates/dremio-master.yaml +++ b/charts/dremio_v2/templates/dremio-master.yaml @@ -235,6 +235,7 @@ spec: {{- include "dremio.coordinator.log.volumeClaimTemplate" $ | nindent 2 }} - metadata: name: dremio-master-volume + {{- include "dremio.coordinator.volumeClaimAnnotations" $ | nindent 6}} spec: accessModes: ["ReadWriteOnce"] {{- include "dremio.coordinator.storageClass" $ | nindent 6 }} From 7f5c117f73bb197e91cf2841a4143fc2113bf96a Mon Sep 17 00:00:00 2001 From: Brandon <34108590+brandonaikey@users.noreply.github.com> Date: Mon, 2 Mar 2026 15:54:52 -0600 Subject: [PATCH 5/6] Update values.yaml Add `volumeClaimAnnotations` for dremio-master PVC to `coordinator`. --- charts/dremio_v2/values.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/charts/dremio_v2/values.yaml b/charts/dremio_v2/values.yaml index b41a327f..990f4f9e 100644 --- a/charts/dremio_v2/values.yaml +++ b/charts/dremio_v2/values.yaml @@ -52,6 +52,9 @@ coordinator: # the provisioned and maximum performance of the disk. volumeSize: 512Gi + # Annotations specifically for the dremio-master PVC. + #volumeClaimAnnotations: {} + # Kubernetes Service Account # Uncomment below to use a custom Kubernetes service account for the coordinator. #serviceAccount: "" From 3f22f3a4c99da48a014359f0a353764f6a079762 Mon Sep 17 00:00:00 2001 From: Brandon <34108590+brandonaikey@users.noreply.github.com> Date: Tue, 7 Apr 2026 17:16:39 -0500 Subject: [PATCH 6/6] Update _helpers_coordinator.tpl --- charts/dremio_v2/templates/_helpers_coordinator.tpl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/charts/dremio_v2/templates/_helpers_coordinator.tpl b/charts/dremio_v2/templates/_helpers_coordinator.tpl index 1d4d8682..127cbc02 100644 --- a/charts/dremio_v2/templates/_helpers_coordinator.tpl +++ b/charts/dremio_v2/templates/_helpers_coordinator.tpl @@ -247,3 +247,13 @@ Coordinator - Active Processor Count {{- $coordinatorCpu -}} {{- end -}} {{- end -}} + +{{/* +Coordinator - Volume Claim Annotations +*/}} +{{- define "dremio.coordinator.volumeClaimAnnotations" -}} +{{- if $.Values.coordinator.volumeClaimAnnotations -}} +annotations: + {{- toYaml $.Values.coordinator.volumeClaimAnnotations | nindent 2 }} +{{- end -}} +{{- end -}}