Skip to content

Commit 2ffb416

Browse files
fix run_with_metrics_server
1 parent e94a583 commit 2ffb416

1 file changed

Lines changed: 5 additions & 16 deletions

File tree

src/dremioai/servers/mcp.py

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -221,25 +221,14 @@ def run_with_metrics_server(
221221
transport: Transport type
222222
metrics_server: Optional metrics server to run concurrently
223223
"""
224-
metrics_task = None
225224
if metrics_server:
226225
# Start metrics server as background task for all transports
227226
log.logger("server_startup").info("Starting metrics server as background task")
228-
metrics_task = asyncio.create_task(metrics_server.serve())
229-
230-
async def cleanup_metrics_server():
231-
if metrics_task is not None:
232-
metrics_task.cancel()
233-
try:
234-
await metrics_task
235-
except asyncio.CancelledError as e:
236-
log.logger("metrics_server").warning(f"Metrics server stopped: {e}")
237-
238-
try:
239-
# Let app.run() handle its own transport logic
240-
app.run(transport=transport.value)
241-
finally:
242-
asyncio.run(cleanup_metrics_server())
227+
228+
asyncio.run(metrics_server.serve())
229+
230+
231+
app.run(transport=transport.value)
243232

244233

245234
def _mode() -> List[str]:

0 commit comments

Comments
 (0)