Exclude credentials and non-flag-aware models from LD flag keys

- Add _flag_exclude ClassVar to FlagAwareMixin; Dremio excludes uri,
  raw_pat, raw_project_id (connection credentials, not feature flags)
- Change Tools from FlagAwareModel to plain BaseModel
- get() skips LD lookup for excluded fields
- collect_flag_keys() skips excluded fields
- Golden keys reduced to 12 meaningful feature flags

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: aniket-s-kulkarni

src/dremioai/config/settings.py

@@ -37,6 +37,7 @@
     Any,
     Callable,
     Literal,
+    ClassVar,
     Tuple,
     get_args,
     get_type_hints,
@@ -81,8 +82,11 @@ def get(self, field_name: str):
 # unaffected by remote flag state.
 class FlagAwareMixin(GetterMixin):
     _flag_prefix: str = ""
+    _flag_exclude: ClassVar[frozenset[str]] = frozenset()
 
     def get(self, field_name: str):
+        if field_name in self._flag_exclude:
+            return super().get(field_name)
         key = f"{self._flag_prefix}.{field_name}" if self._flag_prefix else field_name
         return FeatureFlagManager.instance().get_flag(
             key, super().get(field_name)
@@ -109,7 +113,7 @@ def _resolve_tools_settings(server_mode: Union[ToolType, int, str]) -> ToolType:
     return server_mode
 
 
-class Tools(FlagAwareModel):
+class Tools(BaseModel):
     server_mode: Annotated[
         Optional[Union[ToolType, int, str]], AfterValidator(_resolve_tools_settings)
     ] = Field(default=ToolType.FOR_SELF)
@@ -219,6 +223,8 @@ def enabled(self) -> bool:
 
 
 class Dremio(FlagAwareModel):
+    _flag_exclude: ClassVar[frozenset[str]] = frozenset({"uri", "raw_pat", "raw_project_id"})
+
     uri: Annotated[
         Union[str, HttpUrl, DremioCloudUri], AfterValidator(_resolve_dremio_uri)
     ]
@@ -413,8 +419,11 @@ def _propagate_flag_prefixes(obj: BaseModel, prefix: str):
 def collect_flag_keys(model_cls: type, prefix: str = "") -> list[str]:
     """Recursively collect all LD flag keys from a FlagAwareMixin model class."""
     keys = []
+    excluded = getattr(model_cls, "_flag_exclude", frozenset())
     hints = get_type_hints(model_cls, include_extras=True)
     for name in model_cls.model_fields:
+        if name in excluded:
+            continue
         key = f"{prefix}.{name}" if prefix else name
         annotation = hints[name]
         # Unwrap Optional[X] (Union[X, None]) to get the inner type X.

tests/config/golden_flag_keys.yaml

@@ -9,9 +9,5 @@ flag_keys:
 - dremio.enable_search
 - dremio.metrics.enabled
 - dremio.metrics.port
-- dremio.raw_pat
-- dremio.raw_project_id
-- dremio.uri
 - dremio.wlm.engine_name
 - log_level
-- tools.server_mode

tests/config/test_launchdarkly_integration.py

@@ -172,10 +172,6 @@ def test_flag_prefix_propagation(accessor, expected, overrides):
     assert accessor(cfg)._flag_prefix == expected
 
 
-def test_flag_prefix_tools():
-    cfg = settings.Settings.model_validate({})
-    assert cfg.tools._flag_prefix == "tools"
-
 
 # -- FlagAwareMixin.get() with LD overrides -----------------------------------