Skip to content

Commit ebbda6c

Browse files
committed
Replace deprecated apt_key (3)
1 parent 12f9cb6 commit ebbda6c

File tree

11 files changed

+113
-54
lines changed

11 files changed

+113
-54
lines changed

.devcontainer/docker-compose.override.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,5 @@
22
services:
33
ansible:
44
image: "ghcr.io/ansible/community-ansible-dev-tools:latest"
5+
app_vm:
6+
image: ghcr.io/hicknhack-software/ansible-target:jammy

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
*.retry
22
tests/docker-sshkey*
3+
.ansible

apache/passenger/defaults/main.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
---
22
apache_passenger_install: apt # or gem
33
apache_passenger_state: "latest"
4-
apache_passenger_key_id: "16378A33A6EF16762922526E561F9B9CAC40B2F7"
5-
apache_passenger_key_server: "keyserver.ubuntu.com"
6-
apache_passenger_apt_repo: "deb https://oss-binaries.phusionpassenger.com/apt/passenger {{ ansible_lsb.codename }} main"
4+
# apache_passenger_key_id: "16378A33A6EF16762922526E561F9B9CAC40B2F7"
5+
# apache_passenger_key_server: "keyserver.ubuntu.com"
6+
apache_passenger_key_url: "https://oss-binaries.phusionpassenger.com/auto-software-signing-gpg-key.txt"
7+
apache_passenger_apt_uri: "https://oss-binaries.phusionpassenger.com/apt/passenger"
78

89
# apache_passenger_install: gem
910
apache_passenger_gem_version: ">1"

apache/passenger/tasks/apt_install.yml

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,25 +5,37 @@
55
- "gpg"
66
- "apt-transport-https"
77
- "ca-certificates"
8+
- "python3-debian"
89
state: latest
910
update_cache: true
1011
cache_valid_time: 3600
1112

12-
- name: Install | add key
13-
ansible.builtin.apt_key:
14-
keyserver: "{{ apache_passenger_key_server }}"
15-
id: "{{ apache_passenger_key_id }}"
13+
# note: old keychain is no longer supported!
14+
# - name: Install | add key
15+
# ansible.builtin.apt_key:
16+
# keyserver: "{{ apache_passenger_key_server }}"
17+
# id: "{{ apache_passenger_key_id }}"
1618

17-
- name: Install | add repo
18-
ansible.builtin.apt_repository:
19-
repo: "{{ apache_passenger_apt_repo }}"
19+
# - name: Install | add repo
20+
# ansible.builtin.apt_repository:
21+
# repo: "{{ apache_passenger_apt_repo }}"
22+
23+
- name: Install | Add repo
24+
ansible.builtin.deb822_repository:
25+
name: Phusion Passenger
26+
types: deb
27+
uris: ["{{ apache_passenger_apt_uri }}"]
28+
suites: ["{{ ansible_lsb.codename }}"]
29+
components: [main]
30+
architectures: [amd64]
31+
signed_by: "{{ apache_passenger_key_url }}"
32+
register: repo_result
2033

2134
- name: Install | packages
2235
ansible.builtin.apt:
2336
pkg: "{{ apache_passenger_package }}"
2437
state: "{{ apache_passenger_state }}"
25-
update_cache: true
26-
cache_valid_time: 3600
38+
update_cache: "{{ repo_result.changed | bool }}"
2739
notify: Restart apache
2840

2941
- name: Install | enable module

nginx/passenger/defaults/main.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@ passenger_cloak_headers: true
1111
# app_hosts: "www.example.com example.com en.example.com de.example.de"
1212
app_hosts: "{{ app_domain }}"
1313

14+
apache_passenger_key_url: "https://oss-binaries.phusionpassenger.com/auto-software-signing-gpg-key.txt"
15+
apache_passenger_apt_uri: "https://oss-binaries.phusionpassenger.com/apt/passenger"
16+
1417
passenger_variables:
1518
passenger_enabled: "on"
1619
passenger_ruby: "/home/{{ app_user }}/.rvm/wrappers/ruby-{{ ruby_version }}/ruby"

nginx/passenger/tasks/main.yml

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,28 +5,42 @@
55
- "gpg"
66
- "apt-transport-https"
77
- "ca-certificates"
8+
- "python3-debian"
89
state: latest
910
update_cache: true
1011
cache_valid_time: 3600
1112

12-
- name: Apt | Add key for passenger repos
13-
ansible.builtin.apt_key:
14-
url: http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x561F9B9CAC40B2F7
15-
id: AC40B2F7
16-
state: present
17-
1813
- name: Apt | Add passenger repo
19-
ansible.builtin.apt_repository:
20-
repo: "deb https://oss-binaries.phusionpassenger.com/apt/passenger {{ ansible_lsb.codename }} main"
21-
state: present
22-
update_cache: true
14+
ansible.builtin.deb822_repository:
15+
name: Phusion Passenger
16+
types: deb
17+
uris: ["{{ apache_passenger_apt_uri }}"]
18+
suites: ["{{ ansible_lsb.codename }}"]
19+
components: [main]
20+
architectures: [amd64]
21+
signed_by: "{{ apache_passenger_key_url }}"
22+
register: repo_result
23+
24+
# old apt_key no longer works!
25+
# - name: Apt | Add key for passenger repos
26+
# ansible.builtin.apt_key:
27+
# url: http://keyserver.ubuntu.com/pks/lookup?op=get&search=0x561F9B9CAC40B2F7
28+
# id: AC40B2F7
29+
# state: present
30+
31+
# - name: Apt | Add passenger repo
32+
# ansible.builtin.apt_repository:
33+
# repo: "deb https://oss-binaries.phusionpassenger.com/apt/passenger {{ ansible_lsb.codename }} main"
34+
# state: present
35+
# update_cache: true
2336

2437
- name: Pkg | Install nginx passenger packages
2538
ansible.builtin.apt:
2639
state: present
2740
pkg:
2841
- "nginx-extras"
2942
- "passenger"
43+
update_cache: "{{ repo_result.changed | bool }}"
3044
notify: Nginx restart
3145

3246
- name: Service | Ensure nginx is running

nginx/server/defaults/main.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
---
22
nginx_install: official # or "apt" or "ppa"
3-
nginx_official_key_id: "573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62"
4-
nginx_official_key_servers:
5-
- keyserver.ubuntu.com
6-
- pgp.mit.edu
7-
nginx_official_repo: "deb http://nginx.org/packages/ubuntu {{ ansible_lsb.codename }} nginx"
3+
# nginx_official_key_id: "573BFD6B3D8FBC641079A6ABABF5BD827BD9BF62"
4+
# nginx_official_key_servers:
5+
# - keyserver.ubuntu.com
6+
# - pgp.mit.edu
7+
nginx_official_key_url: "https://nginx.org/keys/nginx_signing.key"
8+
nginx_official_repo_uri: "https://nginx.org/packages/ubuntu"
89

910
# name of the system user that runs nginx
1011
nginx_user: "www-data"

nginx/server/tasks/Debian.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,20 @@
1515
- "gpg"
1616
- "apt-transport-https"
1717
- "ca-certificates"
18+
- "python3-debian"
1819
state: latest
1920
update_cache: true
2021
cache_valid_time: 3600
2122

22-
- name: Debian | Add official key
23-
ansible.builtin.apt_key:
24-
keyserver: "{{ item }}"
25-
id: "{{ nginx_official_key_id }}"
26-
loop: "{{ nginx_official_key_servers }}"
27-
retries: 2
28-
delay: 1
29-
30-
- name: Install | Add repo
31-
ansible.builtin.apt_repository:
32-
repo: "{{ nginx_official_repo }}"
23+
- name: Debian | Add repo
24+
ansible.builtin.deb822_repository:
25+
name: NGINX
26+
types: deb
27+
uris: ["{{ nginx_official_repo_uri }}"]
28+
suites: ["{{ ansible_lsb.codename }}"]
29+
components: [nginx]
30+
architectures: [amd64]
31+
signed_by: "{{ nginx_official_key_url }}"
3332

3433
- name: Debian | Packages
3534
ansible.builtin.apt:

postgresql/tasks/Debian.yml

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,33 @@
55
- "gpg"
66
- "apt-transport-https"
77
- "ca-certificates"
8+
- "python3-debian"
89
state: latest
910
update_cache: true
1011
cache_valid_time: 86400
1112

12-
- name: Debian | Add repo key
13-
ansible.builtin.apt_key:
14-
url: "{{ postgresql_apt_key }}"
13+
- name: Install | Add repo
14+
ansible.builtin.deb822_repository:
15+
name: Postgresql
16+
types: deb
17+
uris: ["{{ postgresql_apt_url }}"]
18+
suites: ["{{ ansible_lsb.codename }}-pgdg"]
19+
components: [main]
20+
architectures: [amd64]
21+
signed_by: "{{ postgresql_apt_key }}"
22+
register: repo_result
1523

16-
- name: Debian | Add repo
17-
ansible.builtin.apt_repository:
18-
repo: "{{ postgresql_apt_repo }}"
24+
# note: apt_key no longer works
25+
# - name: Debian | Add repo key
26+
# ansible.builtin.apt_key:
27+
# url: "{{ postgresql_apt_key }}"
28+
29+
# - name: Debian | Add repo
30+
# ansible.builtin.apt_repository:
31+
# repo: "{{ postgresql_apt_repo }}"
1932

2033
- name: Debian | Packages
2134
ansible.builtin.apt:
2235
name: "{{ postgresql_packages + postgresql_python_packages | flatten }}"
2336
state: latest
24-
update_cache: true
25-
cache_valid_time: 86400
37+
update_cache: "{{ repo_result.changed | bool }}"

postgresql/vars/Debian.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ postgresql_python_packages:
66

77
postgresql_apt_url: "https://apt.postgresql.org/pub/repos/apt"
88
postgresql_apt_key: "{{ postgresql_apt_url }}/ACCC4CF8.asc"
9-
postgresql_apt_repo: "deb {{ postgresql_apt_url }}/ {{ ansible_lsb.codename }}-pgdg main"
9+
# postgresql_apt_repo: "deb {{ postgresql_apt_url }}/ {{ ansible_lsb.codename }}-pgdg main"
1010

1111
postgresql_config_basepath: "/etc/postgresql"
1212
postgresql_data_basepath: "/var/lib/postgresql"

0 commit comments

Comments
 (0)