Deferred from the codebase convergence work. Every fix here renames or reshapes a published symbol of this library, so it is a backward-compatibility break and was deliberately left out of the non-breaking follow-up.
Summary
The raw bytes of a screenshot are called content in one half of the codebase and data in the other.
Details
content - 8 sites, including the public saveScreenshotContent().data - 5 sites, including the protected $lastScreenshotData property.
Both sides are published surface. saveScreenshotContent() is effectively part of the contract, and $lastScreenshotData is protected on a non-final class, so subclasses can depend on it - the in-repo ProfiledScreenshotContext test double writes to it directly, which demonstrates the extension point is real and in use.
content has the larger share and the more prominent member, so it is the likely canonical, but the decision needs to be deliberate because renaming the property breaks subclasses silently rather than loudly.
Deferred from the codebase convergence work. Every fix here renames or reshapes a published symbol of this library, so it is a backward-compatibility break and was deliberately left out of the non-breaking follow-up.
Summary
The raw bytes of a screenshot are called
contentin one half of the codebase anddatain the other.Details
content- 8 sites, including the publicsaveScreenshotContent().data- 5 sites, including the protected$lastScreenshotDataproperty.Both sides are published surface.
saveScreenshotContent()is effectively part of the contract, and$lastScreenshotDatais protected on a non-final class, so subclasses can depend on it - the in-repoProfiledScreenshotContexttest double writes to it directly, which demonstrates the extension point is real and in use.contenthas the larger share and the more prominent member, so it is the likely canonical, but the decision needs to be deliberate because renaming the property breaks subclasses silently rather than loudly.