fix(RequestStaticValidateToInjectRector): check extends method (#68)

* fix(RequestStaticValidateToInjectRector): check extends method

Co-authored-by: Anthony Clark <[email protected]>

Author: lxShaDoWxl

src/Rector/StaticCall/RequestStaticValidateToInjectRector.php

@@ -11,9 +11,11 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Type\ObjectType;
 use Rector\Core\NodeManipulator\ClassMethodManipulator;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Reflection\ReflectionResolver;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -29,7 +31,8 @@ final class RequestStaticValidateToInjectRector extends AbstractRector
     private array $requestObjectTypes = [];
 
     public function __construct(
-        private readonly ClassMethodManipulator $classMethodManipulator
+        private readonly ClassMethodManipulator $classMethodManipulator,
+        private readonly ReflectionResolver $reflectionResolver
     ) {
         $this->requestObjectTypes = [new ObjectType('Illuminate\Http\Request'), new ObjectType('Request')];
     }
@@ -77,7 +80,7 @@ public function getNodeTypes(): array
     }
 
     /**
-     * @param StaticCall|FuncCall $node
+     * @param  StaticCall|FuncCall  $node
      */
     public function refactor(Node $node): ?Node
     {
@@ -120,6 +123,15 @@ private function shouldSkip(StaticCall|FuncCall $node): bool
             return true;
         }
 
+        $classMethod = $this->betterNodeFinder->findParentType($node, ClassMethod::class);
+        if ($classMethod instanceof ClassMethod) {
+            $classMethodReflection = $this->reflectionResolver->resolveMethodReflectionFromClassMethod($classMethod);
+            if ($classMethodReflection?->getPrototype()?->getDeclaringClass()?->getName() !== $class->namespacedName?->toString()
+            ) {
+                return true;
+            }
+        }
+
         return ! $this->isName($node, 'request');
     }
 }

tests/Rector/StaticCall/RequestStaticValidateToInjectRector/Fixture/function_extends.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\StaticCall\RequestStaticValidateToInjectRector\Fixture;
+
+class FunctionExt1
+{
+    public function store()
+    {
+    }
+}
+
+class FunctionExt2 extends FunctionExt1
+{
+    public function store()
+    {
+        $validatedData = request('foo');
+    }
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\StaticCall\RequestStaticValidateToInjectRector\Fixture;
+
+class FunctionExt1
+{
+    public function store()
+    {
+    }
+}
+
+class FunctionExt2 extends FunctionExt1
+{
+    public function store()
+    {
+        $validatedData = request('foo');
+    }
+}
+
+?>

tests/Rector/StaticCall/RequestStaticValidateToInjectRector/Fixture/function_trait.php.inc

@@ -0,0 +1,45 @@
+<?php
+
+namespace RectorLaravel\Tests\Rector\StaticCall\RequestStaticValidateToInjectRector\Fixture;
+
+class FunctionExt1
+{
+    public function store()
+    {
+    }
+}
+trait FunctionTrait{
+    public function store()
+    {
+        $validatedData = request('foo');
+    }
+}
+class FunctionExt2 extends FunctionExt1
+{
+    use FunctionTrait;
+}
+
+?>
+-----
+<?php
+
+namespace RectorLaravel\Tests\Rector\StaticCall\RequestStaticValidateToInjectRector\Fixture;
+
+class FunctionExt1
+{
+    public function store()
+    {
+    }
+}
+trait FunctionTrait{
+    public function store()
+    {
+        $validatedData = request('foo');
+    }
+}
+class FunctionExt2 extends FunctionExt1
+{
+    use FunctionTrait;
+}
+
+?>