Fix: StartOfWeek and EndOfWeek methods change original Carbon instance Unexpectedly #304

kuafuRace · kuafuRace · commit 598f6a11ccf7 · 2025-05-15T09:42:32.000+08:00
diff --git a/boundary.go b/boundary.go
@@ -99,7 +99,7 @@ func (c *Carbon) StartOfWeek() *Carbon {
 	if dayOfWeek == weekStartsAt {
 		return c.StartOfDay()
 	}
-	return c.SubDays(int(DaysPerWeek+dayOfWeek-weekStartsAt) % DaysPerWeek).StartOfDay()
+	return c.Copy().SubDays(int(DaysPerWeek+dayOfWeek-weekStartsAt) % DaysPerWeek).StartOfDay()
 }
 
 // EndOfWeek returns a Carbon instance for end of the week.
@@ -111,7 +111,7 @@ func (c *Carbon) EndOfWeek() *Carbon {
 	if dayOfWeek == weekEndsAt {
 		return c.EndOfDay()
 	}
-	return c.AddDays(int(DaysPerWeek-dayOfWeek+weekEndsAt) % DaysPerWeek).EndOfDay()
+	return c.Copy().AddDays(int(DaysPerWeek-dayOfWeek+weekEndsAt) % DaysPerWeek).EndOfDay()
 }
 
 // StartOfDay returns a Carbon instance for start of the day.

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ func (c Carbon) StartOfWeek() Carbon {`
`99`	`99`	`if dayOfWeek == weekStartsAt {`
`100`	`100`	`return c.StartOfDay()`
`101`	`101`	`}`
`102`		`- return c.SubDays(int(DaysPerWeek+dayOfWeek-weekStartsAt) % DaysPerWeek).StartOfDay()`
	`102`	`+ return c.Copy().SubDays(int(DaysPerWeek+dayOfWeek-weekStartsAt) % DaysPerWeek).StartOfDay()`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`// EndOfWeek returns a Carbon instance for end of the week.`
`@@ -111,7 +111,7 @@ func (c Carbon) EndOfWeek() Carbon {`
`111`	`111`	`if dayOfWeek == weekEndsAt {`
`112`	`112`	`return c.EndOfDay()`
`113`	`113`	`}`
`114`		`- return c.AddDays(int(DaysPerWeek-dayOfWeek+weekEndsAt) % DaysPerWeek).EndOfDay()`
	`114`	`+ return c.Copy().AddDays(int(DaysPerWeek-dayOfWeek+weekEndsAt) % DaysPerWeek).EndOfDay()`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`// StartOfDay returns a Carbon instance for start of the day.`