Skip to content

Commit 9f4d3fc

Browse files
committed
SubaruEj20gDefaultRev triggering watchdog restart
1 parent 5a69264 commit 9f4d3fc

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

unit_tests/tests/trigger/test_real_subaru_ej20g.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,11 @@ TEST(real, SubaruEj20gDefaultCrankingSeparateTrigger) {
174174
// Test also has RPM falling to zero twice
175175
// While real car was runnig fine while capturing this CSV
176176
// TODO: investigate
177+
// TODO: this test also triggers a watchdog warning after clearing the EngineTestHelper!
177178
TEST(real, SubaruEj20gDefaultRev) {
179+
extern bool unitTestTaskNoFastCallWhileAdvancingTimeHack;
180+
unitTestTaskNoFastCallWhileAdvancingTimeHack = true;
181+
178182
EngineCsvReader reader(/*triggerCount*/ 1, /* vvtCount */ 1);
179183

180184
/* 1 - cam

unit_tests/tests/trigger/test_toyota_3_tooth_cam.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
#include "logicdata_csv_reader.h"
33

44
TEST(Toyota3ToothCam, RealEngineRunning) {
5-
extern bool unitTestTaskPrecisionHack;
6-
unitTestTaskPrecisionHack = true;
75
extern bool unitTestTaskNoFastCallWhileAdvancingTimeHack;
86
unitTestTaskNoFastCallWhileAdvancingTimeHack = true;
97

@@ -44,9 +42,9 @@ TEST(Toyota3ToothCam, RealEngineRunning) {
4442
ASSERT_EQ(3078, round(Sensor::getOrZero(SensorType::Rpm)));
4543

4644
// TODO: why warnings?
47-
// C6103 C9002
48-
ASSERT_EQ(2u, eth.recentWarnings()->getCount());
49-
ASSERT_EQ(ObdCode::CUSTOM_PRIMARY_TOO_MANY_TEETH, eth.recentWarnings()->get(1).Code);
45+
// C9002
46+
ASSERT_EQ(1u, eth.recentWarnings()->getCount());
47+
ASSERT_EQ(ObdCode::CUSTOM_PRIMARY_TOO_MANY_TEETH, eth.recentWarnings()->get(0).Code);
5048
}
5149

5250
static void test3tooth(size_t revsBeforeVvt, size_t teethBeforeVvt, bool expectSync, int expectCamResyncCounter) {

0 commit comments

Comments
 (0)