Skip to content

Commit 4676508

Browse files
committed
Tests fix
1 parent 69ecbcd commit 4676508

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

firmware/boards/port.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,7 @@ class Configuration {
172172
struct {
173173
bool RusEfiTx:1;
174174
bool RusEfiTxDiag:1;
175-
CanEgtProtocol ExtraCanProtocol:4;
176-
uint8_t Reserved0:3; // Keep some room for future protocol expansion without breaking the config format
175+
CanEgtProtocol ExtraCanProtocol:5;
177176
bool ExtraCanChannelEnabled:1; // Is the channel actually enabled in the selected protocol
178177

179178
uint8_t RusEfiIdx;

test/tests/test_config.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ TEST(ConfigLayout, BinaryCompatibility_AfrChannelSettings) {
140140

141141
EXPECT_TRUE(config.afr[0].RusEfiTx);
142142
EXPECT_TRUE(config.afr[0].RusEfiTxDiag);
143-
EXPECT_TRUE(config.afr[0].ExtraCanProtocol == CanProtocol::AemNet);
143+
EXPECT_TRUE(config.afr[0].ExtraCanProtocol == CanAfrProtocol::AemNet);
144144
EXPECT_EQ(config.afr[0].RusEfiIdx, 5);
145145
EXPECT_EQ(config.afr[0].ExtraCanIdOffset, 10);
146146

@@ -153,7 +153,7 @@ TEST(ConfigLayout, BinaryCompatibility_AfrChannelSettings) {
153153

154154
EXPECT_FALSE(config.afr[1].RusEfiTx);
155155
EXPECT_TRUE(config.afr[1].RusEfiTxDiag);
156-
EXPECT_TRUE(config.afr[1].ExtraCanProtocol == CanProtocol::None);
156+
EXPECT_TRUE(config.afr[1].ExtraCanProtocol == CanAfrProtocol::None);
157157
EXPECT_EQ(config.afr[1].RusEfiIdx, 7);
158158
EXPECT_EQ(config.afr[1].ExtraCanIdOffset, 15);
159159
}
@@ -177,22 +177,24 @@ TEST(ConfigLayout, BinaryCompatibility_EgtChannelSettings) {
177177

178178
EXPECT_TRUE(config.egt[0].RusEfiTx);
179179
EXPECT_FALSE(config.egt[0].RusEfiTxDiag);
180-
EXPECT_TRUE(config.egt[0].ExtraCanProtocol == CanProtocol::AemNet);
180+
EXPECT_TRUE(config.egt[0].ExtraCanProtocol == CanEgtProtocol::AemNet0305);
181181
EXPECT_EQ(config.egt[0].RusEfiIdx, 3);
182182
EXPECT_EQ(config.egt[0].ExtraCanIdOffset, 8);
183+
EXPECT_EQ(config.egt[0].ExtraCanChannelEnabled, 0);
183184

184185
// Write second EGT channel
185186
offset += ConfigSizes::EGT_CHANNEL;
186-
uint8_t bitfield1 = 0b00000010; // RusEfiTx=0, RusEfiTxDiag=1, ExtraCanProtocol=0
187+
uint8_t bitfield1 = 0b10000010; // RusEfiTx=0, RusEfiTxDiag=1, ExtraCanProtocol=0
187188
WriteAtOffset(config, offset, bitfield1);
188189
WriteAtOffset(config, offset + 1, static_cast<uint8_t>(7)); // RusEfiIdx
189190
WriteAtOffset(config, offset + 2, static_cast<uint8_t>(15)); // ExtraCanIdOffset
190191

191192
EXPECT_FALSE(config.egt[1].RusEfiTx);
192193
EXPECT_TRUE(config.egt[1].RusEfiTxDiag);
193-
EXPECT_TRUE(config.egt[1].ExtraCanProtocol == CanProtocol::None);
194+
EXPECT_TRUE(config.egt[1].ExtraCanProtocol == CanEgtProtocol::None);
194195
EXPECT_EQ(config.egt[1].RusEfiIdx, 7);
195196
EXPECT_EQ(config.egt[1].ExtraCanIdOffset, 15);
197+
EXPECT_EQ(config.egt[1].ExtraCanChannelEnabled, 1);
196198
}
197199

198200
TEST(ConfigLayout, BinaryCompatibility_HeaterConfig) {

0 commit comments

Comments
 (0)