Skip to content

Commit 86ecc4b

Browse files
author
Dan Wilson
authored
fix low hanging lint issues (#425)
1 parent ca55d7d commit 86ecc4b

File tree

90 files changed

+32274
-1232
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+32274
-1232
lines changed

‎package-lock.json

Lines changed: 30805 additions & 266 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
"serve": "npx http-server ./build -p 3001",
1010
"test": "react-scripts test",
1111
"eject": "react-scripts eject",
12-
"lint": "npm run lint:js & npm run lint:styles",
13-
"lint:fix": "npm run lint:js:fix & npm run lint:styles:fix",
12+
"lint": "npm run lint:js && npm run lint:styles",
13+
"lint:fix": "npm run lint:js:fix && npm run lint:styles:fix",
1414
"lint:js": "eslint --ext .js,.jsx --ignore-path .gitignore .",
1515
"lint:js:fix": "eslint --fix --ext .js,.jsx --ignore-path .gitignore .",
1616
"lint:styles": "stylelint --ignore-path .gitignore '{**/*,*}.{css,sass,scss,html}'",

‎src/components/pages/build/cards-view/card.module.scss

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,28 @@
11
.card {
2-
padding: 10px;
3-
background-color: white;
4-
display: flex;
5-
align-items: center;
6-
margin: 0 0 1rem 0;
7-
min-width: 800px;
8-
overflow: hidden;
9-
border-radius: 10px;
10-
box-shadow: 0 0 1px rgba(40, 41, 61, 0.08), 0 0.5px 2px rgba(96, 97, 112, 0.16);
11-
&:hover {
12-
box-shadow: 0 1px 6px -3px rgba(0, 0, 0, 0.5);
13-
box-shadow: 2px 0 -3px rgba(40, 41, 61, 0.08), 0 2px 2px rgba(96, 97, 112, 0.16);
14-
}
15-
&-message {
16-
padding: 1rem;
17-
}
2+
display: flex;
3+
align-items: center;
4+
min-width: 800px;
5+
padding: 10px;
6+
margin: 0 0 1rem 0;
7+
overflow: hidden;
8+
background-color: white;
9+
border-radius: 10px;
10+
box-shadow: 0 0 1px rgba(40, 41, 61, 0.08), 0 0.5px 2px rgba(96, 97, 112, 0.16);
11+
12+
&:hover {
13+
box-shadow: 0 1px 6px -3px rgba(0, 0, 0, 0.5);
14+
box-shadow: 2px 0 -3px rgba(40, 41, 61, 0.08), 0 2px 2px rgba(96, 97, 112, 0.16);
15+
}
16+
17+
&-message {
18+
padding: 1rem;
19+
}
1820
}
1921

2022
@media only screen and (max-width: 992px) {
21-
.card {
22-
min-width: 100%;
23-
max-width: 100%;
24-
overflow: auto;
25-
}
23+
.card {
24+
min-width: 100%;
25+
max-width: 100%;
26+
overflow: auto;
27+
}
2628
}

‎src/components/pages/build/cards-view/cards-view.module.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
.card-list {
2-
margin: 1rem 2rem;
3-
display: flex;
4-
flex-direction: column;
5-
align-items: center;
6-
margin-top: 40px;
2+
display: flex;
3+
flex-direction: column;
4+
align-items: center;
5+
margin: 1rem 2rem;
6+
margin-top: 40px;
77
}
88

99
.message {
10-
padding: 1rem;
11-
background-color: white;
12-
border: 1px lightgrey solid;
10+
padding: 1rem;
11+
background-color: white;
12+
border: 1px lightgrey solid;
1313
}

‎src/components/pages/build/graph-view/diagram/controls/controls.module.scss

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,33 +4,38 @@
44
right: 15px;
55
display: flex;
66
flex-flow: column;
7+
78
&-group {
89
display: flex;
910
flex-flow: column;
10-
filter: drop-shadow(0px 2px 4px rgba(0, 0, 0, 0.15));
11+
filter: drop-shadow(0 2px 4px rgba(0, 0, 0, 0.15));
1112
}
13+
1214
.btn {
13-
background: #ffffff;
14-
border: 1px solid #ffffff;
1515
box-sizing: border-box;
16-
border-radius: 4px;
17-
filter: drop-shadow(0px 2px 4px rgba(0, 0, 0, 0.15));
18-
width: 22px;
19-
height: 22px;
20-
margin-bottom: 8px;
2116
display: flex;
2217
align-items: center;
2318
justify-content: center;
19+
width: 22px;
20+
height: 22px;
21+
margin-bottom: 8px;
2422
cursor: pointer;
23+
background: #fff;
24+
filter: drop-shadow(0 2px 4px rgba(0, 0, 0, 0.15));
25+
border: 1px solid #fff;
26+
border-radius: 4px;
27+
2528
&-zoom-in,
2629
&-zoom-out {
27-
filter: none;
2830
margin-bottom: 0;
31+
filter: none;
2932
}
33+
3034
&-zoom-in {
31-
border-radius: 4px 4px 0 0;
3235
border-bottom-color: rgba(151, 151, 151, 0.24);
36+
border-radius: 4px 4px 0 0;
3337
}
38+
3439
&-zoom-out {
3540
border-radius: 0 0 4px 4px;
3641
}

‎src/components/pages/build/graph-view/diagram/custom-nodes/node-default/node-default-widget.module.scss

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,31 @@
33
}
44

55
.node-inner {
6-
max-width: 100%;
7-
width: 100%;
8-
height: 36px;
9-
background-color: #fff;
10-
box-shadow: 0px 0px 2px rgba(40, 41, 61, 0.04), 0px 4px 8px rgba(96, 97, 112, 0.16);
11-
border-radius: 5px;
12-
border: none;
13-
color: black;
6+
position: relative;
147
display: flex;
8+
flex: 1 1 100%;
159
align-items: center;
1610
justify-content: center;
17-
position: relative;
18-
flex: 1 1 100%;
11+
width: 100%;
12+
max-width: 100%;
13+
height: 36px;
14+
color: black;
1915
cursor: pointer;
16+
background-color: #fff;
17+
border: none;
18+
border-radius: 5px;
19+
box-shadow: 0 0 2px rgba(40, 41, 61, 0.04), 0 4px 8px rgba(96, 97, 112, 0.16);
20+
2021
&-selected {
2122
border: 1px solid #2477e5;
2223
}
24+
2325
&-skipped,
2426
&-declined,
2527
&-waiting_on_dependencies {
2628
cursor: not-allowed;
2729
}
30+
2831
&:focus {
2932
outline: none;
3033
}
@@ -34,33 +37,36 @@
3437
position: absolute;
3538
top: 50%;
3639
transform: translateY(-50%);
40+
3741
.circle-port {
3842
width: 5px;
3943
height: 5px;
40-
border-radius: 50%;
4144
background: #2477e5;
4245
border: 1px solid #2477e5;
46+
border-radius: 50%;
4347
}
48+
4449
&-in {
4550
left: -2.5px;
4651
}
52+
4753
&-out {
4854
top: 50%;
4955
right: -2.5px;
5056
}
5157
}
5258

5359
.name {
54-
text-align: center;
55-
font-weight: 500;
60+
margin-top: 7px;
5661
font-size: 10px;
62+
font-weight: 500;
5763
line-height: 14px;
64+
color: rgba(5, 25, 46, 0.7);
5865
text-align: center;
5966
letter-spacing: 0.1px;
60-
color: rgba(5, 25, 46, 0.7);
61-
margin-top: 7px;
6267
overflow-wrap: break-word;
6368
}
69+
6470
.status {
6571
width: 20px;
6672
height: 20px;

‎src/components/pages/build/graph-view/diagram/custom-nodes/node-edge/node-edge-widget.module.scss

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,33 +4,36 @@
44
}
55

66
.node-inner {
7-
width: 100%;
8-
height: 100%;
9-
border-radius: 50%;
10-
appearance: none;
11-
background: #f2f2f2;
12-
border: 1px solid #acacac;
137
position: relative;
14-
padding: 0;
158
display: flex;
169
align-items: center;
1710
justify-content: center;
11+
width: 100%;
12+
height: 100%;
13+
padding: 0;
14+
background: #f2f2f2;
15+
border: 1px solid #acacac;
16+
border-radius: 50%;
17+
appearance: none;
1818
}
1919

2020
.port {
2121
position: absolute;
2222
top: 50%;
2323
transform: translateY(-50%);
24+
2425
.circle-port {
2526
width: 5px;
2627
height: 5px;
27-
border-radius: 50%;
2828
background: #2477e5;
2929
border: 1px solid #2477e5;
30+
border-radius: 50%;
3031
}
32+
3133
&-in {
3234
left: -2.5px;
3335
}
36+
3437
&-out {
3538
top: 50%;
3639
right: -2.5px;
@@ -39,8 +42,8 @@
3942

4043
.fake-icon-stop {
4144
display: block;
42-
background: #8b8b8b;
43-
border-radius: 1px;
4445
width: 8px;
4546
height: 8px;
47+
background: #8b8b8b;
48+
border-radius: 1px;
4649
}

‎src/components/pages/build/graph-view/diagram/diagram.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { CanvasWidget } from '@projectstorm/react-canvas-core';
22
import createEngine, {
3-
DiagramModel, DagreEngine,
3+
DiagramModel, DagreEngine,
44
} from '@projectstorm/react-diagrams';
55
import classNames from 'classnames/bind';
66
import React, {
@@ -138,7 +138,7 @@ const Diagram = (props) => {
138138
useLayoutEffect(() => {
139139
if (nodeModels.length >= 3) {
140140
nodeModels.slice(1, nodeModels.length - 1).forEach((nodeModel) => {
141-
nodeModel.setIsImperativelySelected(nodeModel.getOptions().number == selectedNodeNumber);
141+
nodeModel.setIsImperativelySelected(nodeModel.getOptions().number === selectedNodeNumber);
142142
});
143143
}
144144
}, [nodeModels, selectedNodeNumber]);

‎src/components/pages/build/graph-view/diagram/diagram.module.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.diagram-wrapper {
2-
display: block;
32
position: relative;
3+
display: block;
44
width: 100%;
55
height: 100%;
66
overflow: hidden;

‎src/components/pages/build/graph-view/graph-view.jsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import classNames from 'classnames/bind';
22
import React, { useState } from 'react';
3+
import { useHistory, useParams } from 'react-router-dom';
34
import SplitPane from 'react-split-pane';
45
import './graph-view.scss';
56

@@ -9,8 +10,6 @@ import Diagram from './diagram';
910
import css from './graph-view.module.scss';
1011
import StepInfoDrawer from './step-info-drawer';
1112

12-
import { useHistory, useParams } from 'react-router-dom';
13-
1413
const cx = classNames.bind(css);
1514

1615
const GraphView = (props) => {

‎src/components/pages/build/graph-view/graph-view.module.scss

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,32 @@ $dot-size: 1px;
88
$dot-space: 10px;
99

1010
@mixin grid-bg($dot-color, $bg-color, $dot-size, $dot-space) {
11-
background: linear-gradient(90deg, $bg-color ($dot-space - $dot-size), transparent 1%) center,
12-
linear-gradient($bg-color ($dot-space - $dot-size), transparent 1%) center, $dot-color;
11+
background:
12+
linear-gradient(90deg, $bg-color ($dot-space - $dot-size), transparent 1%) center,
13+
linear-gradient($bg-color ($dot-space - $dot-size), transparent 1%) center,
14+
$dot-color;
1315
background-size: $dot-space $dot-space;
1416
}
1517

1618
.graph {
1719
&-wrapper {
18-
padding: 0;
19-
min-height: 500px;
2020
position: relative;
21+
min-height: 500px;
22+
padding: 0;
23+
2124
@include grid-bg($dot-color, $bg-color-w, $dot-size, $dot-space);
2225
}
26+
2327
&-stages {
28+
position: relative;
2429
width: 100%;
2530
height: 100%;
26-
position: relative;
2731
background: rgba(238, 249, 255, 0.5);
2832
}
33+
2934
&-steps {
35+
position: relative;
3036
width: 100%;
3137
height: 100%;
32-
position: relative;
3338
}
3439
}

‎src/components/pages/build/graph-view/graph-view.scss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,32 @@
11
.Resizer {
2-
background: transparent;
32
z-index: 1;
3+
background: transparent;
44
background-clip: padding-box;
55
}
66

77
.Resizer.horizontal {
8+
position: relative;
9+
width: 100%;
810
height: 3px;
911
padding: 3px 0;
1012
margin: 0;
1113
cursor: row-resize;
12-
width: 100%;
13-
position: relative;
14+
1415
&::before {
15-
content: "";
1616
position: absolute;
17-
left: 0;
17+
top: 3px;
1818
right: 0;
19+
left: 0;
1920
height: 3px;
20-
top: 3px;
21+
content: "";
2122
background: rgba(10, 143, 253, 0.3);
2223
}
2324
}
2425

2526
.Resizer.disabled {
2627
cursor: not-allowed;
2728
}
29+
2830
.Resizer.disabled:hover {
2931
border-color: transparent;
3032
}

0 commit comments

Comments
 (0)