Refactor exception handling for InvalidImageException, add command-line hint for file paths, and bump version to 1.0.3.

Author: drpetersonfernandes

SimpleXisoDrive/InvalidImageException.cs

@@ -0,0 +1,9 @@
+namespace SimpleXisoDrive;
+
+public class InvalidImageException : Exception
+{
+    public InvalidImageException(string message, Exception? inner = null)
+        : base(message, inner)
+    {
+    }
+}

SimpleXisoDrive/Program.cs

@@ -89,6 +89,14 @@ public static async Task<int> Main(string[] args)
                 Console.ForegroundColor = ConsoleColor.Red;
                 var errorMsg = $"ISO file not found at '{isoPath}'";
                 await Console.Error.WriteLineAsync($"Error: {errorMsg}");
+
+                // Add a hint for common command-line mistakes
+                if (args.Length > 2 && !isoPath.Contains(' '))
+                {
+                    Console.ForegroundColor = ConsoleColor.Yellow;
+                    await Console.Error.WriteLineAsync("Hint: If your file path contains spaces, ensure it is wrapped in \"quotes\".");
+                }
+
                 Console.ResetColor();
 
                 // Report this to the API so the developer knows the path was invalid
@@ -143,7 +151,7 @@ public static async Task<int> Main(string[] args)
 
             return 0;
         }
-        catch (VfsContainer.InvalidImageException ex)
+        catch (InvalidImageException ex)
         {
             Console.ForegroundColor = ConsoleColor.Red;
             await Console.Error.WriteLineAsync($"Error: {ex.Message}");
@@ -176,10 +184,10 @@ public static async Task<int> Main(string[] args)
 
             await ErrorLogger.LogErrorAsync(ex, "Fatal error in Main");
 
-            // Always wait for key press if drag-and-drop
-            if (isDragAndDrop || args.Length == 1)
+            // If we are in a context where the window might disappear (Drag & Drop or single arg)
+            if (isDragAndDrop || args.Length <= 1)
             {
-                DebugLogger.WriteLine("\nPress any key to exit.");
+                Console.WriteLine("\nPress any key to exit.");
                 Console.ReadKey();
             }
 

SimpleXisoDrive/SimpleXisoDrive.csproj

@@ -8,8 +8,8 @@
         <Nullable>enable</Nullable>
         <ApplicationIcon>icon\xiso.ico</ApplicationIcon>
         <IsPackable>false</IsPackable>
-        <AssemblyVersion>1.0.2</AssemblyVersion>
-        <FileVersion>1.0.2</FileVersion>
+        <AssemblyVersion>1.0.3</AssemblyVersion>
+        <FileVersion>1.0.3</FileVersion>
         <NeutralLanguage>en</NeutralLanguage>
         <DebugType>embedded</DebugType>
         <DebugSymbols>true</DebugSymbols>

SimpleXisoDrive/VfsContainer.cs

@@ -37,7 +37,13 @@ public VfsContainer(string isoPath)
         catch (Exception ex)
         {
             _isoSt.Dispose();
+
             // Exception is re-thrown and caught by Program.cs, which handles the API reporting.
+            if (ex is InvalidImageException)
+            {
+                throw;
+            }
+
             throw new InvalidImageException($"Failed to read Xbox ISO: {ex.Message}", ex);
         }
     }
@@ -291,12 +297,4 @@ public void Dispose()
         _isoSt.Dispose();
         GC.SuppressFinalize(this);
     }
-
-    public class InvalidImageException : Exception
-    {
-        public InvalidImageException(string message, Exception? inner = null)
-            : base($"{message}. This might be an unsupported ISO format.", inner)
-        {
-        }
-    }
 }

SimpleXisoDrive/XDVDFs/VolumeDescriptor.cs

@@ -148,7 +148,7 @@ public static VolumeDescriptor ReadFrom(IsoSt isoSt)
         }
 
         // If we reach here, sectors were readable but failed validation
-        throw new VfsContainer.InvalidImageException(
+        throw new InvalidImageException(
             "Volume descriptor not found at sector 0 or 32 (including game partition offset). " +
             "This doesn't appear to be a valid Xbox ISO file."
         );