Skip to content

Commit 3711762

Browse files
authored
test(APQ): Simplify test case by using query helper method (#1393)
1 parent f4a80c5 commit 3711762

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

tests/src/Kernel/Framework/AutomaticPersistedQueriesTest.php

+9-15
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,12 @@ public function testAutomaticPersistedQueries(): void {
5252
$this->server->addPersistedQueryInstance($this->pluginApq);
5353
$this->server->save();
5454

55-
$endpoint = $this->server->get('endpoint');
56-
5755
$query = 'query { field_one } ';
58-
$parameters['extensions']['persistedQuery']['sha256Hash'] = 'some random hash';
56+
$extensions = ['persistedQuery' => ['sha256Hash' => 'some random hash']];
5957

6058
// Check we get PersistedQueryNotFound.
61-
$request = Request::create($endpoint, 'GET', $parameters);
62-
$result = $this->container->get('http_kernel')->handle($request);
59+
$result = $this->query('', $this->server, [], $extensions);
60+
6361
$this->assertSame(200, $result->getStatusCode());
6462
$this->assertSame([
6563
'errors' => [
@@ -71,9 +69,8 @@ public function testAutomaticPersistedQueries(): void {
7169
], json_decode($result->getContent(), TRUE));
7270

7371
// Post query to endpoint with a not matching hash.
74-
$content = json_encode(['query' => $query] + $parameters);
75-
$request = Request::create($endpoint, 'POST', [], [], [], ['CONTENT_TYPE' => 'application/json'], $content);
76-
$result = $this->container->get('http_kernel')->handle($request);
72+
$result = $this->query($query, $this->server, [], $extensions, FALSE, Request::METHOD_POST);
73+
7774
$this->assertSame(200, $result->getStatusCode());
7875
$this->assertSame([
7976
'errors' => [
@@ -85,17 +82,14 @@ public function testAutomaticPersistedQueries(): void {
8582
], json_decode($result->getContent(), TRUE));
8683

8784
// Post query to endpoint to get the result and cache it.
88-
$parameters['extensions']['persistedQuery']['sha256Hash'] = hash('sha256', $query);
85+
$extensions['persistedQuery']['sha256Hash'] = hash('sha256', $query);
86+
$result = $this->query($query, $this->server, [], $extensions, FALSE, Request::METHOD_POST);
8987

90-
$content = json_encode(['query' => $query] + $parameters);
91-
$request = Request::create($endpoint, 'POST', [], [], [], ['CONTENT_TYPE' => 'application/json'], $content);
92-
$result = $this->container->get('http_kernel')->handle($request);
9388
$this->assertSame(200, $result->getStatusCode());
9489
$this->assertSame(['data' => ['field_one' => 'this is the field one']], json_decode($result->getContent(), TRUE));
9590

96-
// Execute first request again.
97-
$request = Request::create($endpoint, 'GET', $parameters);
98-
$result = $this->container->get('http_kernel')->handle($request);
91+
// Execute first GET request again.
92+
$result = $this->query($query, $this->server, [], $extensions);
9993
$this->assertSame(200, $result->getStatusCode());
10094
$this->assertSame(['data' => ['field_one' => 'this is the field one']], json_decode($result->getContent(), TRUE));
10195
}

0 commit comments

Comments
 (0)