Finish test coverage with data provider

Author: klausi

tests/src/Kernel/DataProducer/DefaultValueTest.php

@@ -5,7 +5,6 @@
 use Drupal\Core\Session\AccountInterface;
 use Drupal\graphql\GraphQL\Execution\FieldContext;
 use Drupal\graphql\Plugin\GraphQL\DataProducer\Entity\EntityLoad;
-use Drupal\media_test_source\Plugin\media\Source\Test;
 use Drupal\Tests\graphql\Kernel\GraphQLTestBase;
 use GraphQL\Deferred;
 use PHPUnit\Framework\Assert;
@@ -32,16 +31,18 @@ public function testEntityLoadDefaultValue(): void {
 
   /**
    * Test that the legacy dataproducer_populate_default_values setting works.
+   *
+   * @dataProvider settingsProvider
    */
-  public function testLegacyDefaultValueSetting(): void {
+  public function testLegacyDefaultValueSetting(bool $populate_setting, string $testClass): void {
     $this->container->get('config.factory')->getEditable('graphql.settings')
-      ->set('dataproducer_populate_default_values', FALSE)
+      ->set('dataproducer_populate_default_values', $populate_setting)
       ->save();
     $manager = $this->container->get('plugin.manager.graphql.data_producer');
 
     // Manipulate the plugin definitions to use our test class for entity_load.
     $definitions = $manager->getDefinitions();
-    $definitions['entity_load']['class'] = TestLegacyEntityLoad::class;
+    $definitions['entity_load']['class'] = $testClass;
     $reflection = new \ReflectionClass($manager);
     $property = $reflection->getProperty('definitions');
     $property->setAccessible(TRUE);
@@ -50,12 +51,48 @@ public function testLegacyDefaultValueSetting(): void {
     $this->executeDataProducer('entity_load', ['type' => 'node']);
   }
 
+  /**
+   * Data provider for the testLegacyDefaultValueSetting test.
+   */
+  public function settingsProvider(): array {
+    return [
+      [FALSE, TestLegacyEntityLoad::class],
+      [TRUE, TestNewEntityLoad::class],
+    ];
+  }
+
 }
 
+/**
+ * Helper class to test the legacy behavior.
+ */
 class TestLegacyEntityLoad extends EntityLoad {
+
+  /**
+   * {@inheritdoc}
+   */
   public function resolve($type, $id, ?string $language, ?array $bundles, ?bool $access, ?AccountInterface $accessUser, ?string $accessOperation, FieldContext $context): ?Deferred {
+    // Old behavior: no default values applied, so we get NULL here.
     Assert::assertNull($access);
     Assert::assertNull($accessOperation);
     return NULL;
   }
+
+}
+
+/**
+ * Helper class to test the new behavior.
+ */
+class TestNewEntityLoad extends EntityLoad {
+
+  /**
+   * {@inheritdoc}
+   */
+  public function resolve($type, $id, ?string $language, ?array $bundles, ?bool $access, ?AccountInterface $accessUser, ?string $accessOperation, FieldContext $context): ?Deferred {
+    // New behavior: default values are applied.
+    Assert::assertTrue($access);
+    Assert::assertSame('view', $accessOperation);
+    return NULL;
+  }
+
 }