Skip to content

Commit f9e5a05

Browse files
committed
Rework Legacy PNG Icons with Font Awesome SVG
Existing implementation handle icon with PNG, with manual positioning with CSS background image. This PR rework icons with Font Awesome SVG: - Locally venor Font Awesome v5.15.4 `expand-solid.svg` and `compress-solid.svg` - Rework styling with SCSS - Fix accessibility (see Leaflet#110) - Test with Leaflet v1.7.1 - Update demo with above changes Fix Leaflet#98 Fix Leaflet#102 Fix Leaflet#103 Fix Leaflet#110 Fix Leaflet#114 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
1 parent 91c9745 commit f9e5a05

15 files changed

+105
-226
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
node_modules
2+
package-lock.json

Makefile

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
# See the README for installation instructions.
22
UGLIFY = node_modules/.bin/uglifyjs
3+
SASS = node_modules/.bin/sass
34

4-
all: \
5-
$(shell npm install) \
6-
dist/Leaflet.fullscreen.min.js \
5+
.PHONY: all
6+
all: dist/Leaflet.fullscreen.min.js dist/Leaflet.fullscreen.min.css
77

8+
.PHONY: clean
89
clean:
9-
rm -f dist/Leaflet.fullscreen.min.js
10+
rm -f dist/Leaflet.fullscreen.min.js dist/Leaflet.fullscreen.min.css
1011

11-
dist/Leaflet.fullscreen.min.js: dist/Leaflet.fullscreen.js
12-
$(UGLIFY) dist/Leaflet.fullscreen.js > dist/Leaflet.fullscreen.min.js
12+
dist/Leaflet.fullscreen.min.js:
13+
$(UGLIFY) src/Leaflet.fullscreen.js > dist/Leaflet.fullscreen.min.js
1314

14-
.PHONY: clean
15+
dist/Leaflet.fullscreen.min.css:
16+
$(SASS) src/Leaflet.fullscreen.scss dist/Leaflet.fullscreen.min.css

compress-solid.svg

Lines changed: 1 addition & 0 deletions
Loading

dist/Leaflet.fullscreen.min.css

Lines changed: 23 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/Leaflet.fullscreen.min.css.map

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/Leaflet.fullscreen.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/fullscreen.png

-299 Bytes
Binary file not shown.

dist/[email protected]

-420 Bytes
Binary file not shown.

dist/leaflet.fullscreen.css

Lines changed: 0 additions & 40 deletions
This file was deleted.

expand-solid.svg

Lines changed: 1 addition & 0 deletions
Loading

0 commit comments

Comments
 (0)