Resolved intermittent issue that could occur while scanning through target app controls.

Author: Darin Higgins

Disambiguator/DisambiguatorExt.cs

@@ -93,7 +93,7 @@ public override bool Initialize(IPluginHost host)
 
 
         /// <summary>
-        /// Provide our menu item to Keepass
+        /// Provide our menu item to KeePass
         /// </summary>
         /// <param name="t"></param>
         /// <returns></returns>
@@ -281,11 +281,45 @@ private List<UIElement> TraverseControlTree(IntPtr targetWindowHandle, int depth
                 if (uiaObject != null)
                 {
                     //add the root control element to the list
+                    string ID = string.Empty;
+                    string Name = ID;
+                    string Class = ID;
+
+                    //attempt each of these resolutions, but if they fail, just ignore
+                    var msg = "!Failed to resolve!";
+                    try 
+                    { 
+                        ID = uiaObject.GetCurrentPropertyValue(AutomationElement.AutomationIdProperty) as string; 
+                    } 
+                    catch (Exception ex) 
+                    {
+                        Debug("Unable to resolve AutomationID: " + ex.ToString());
+                        ID = msg; 
+                    };
+                    try 
+                    {
+                        Name = uiaObject.GetCurrentPropertyValue(AutomationElement.NameProperty) as string; 
+                    } 
+                    catch (Exception ex)
+                    {
+                        Debug("Unable to resolve Name: " + ex.ToString());
+                        Name = msg; 
+                    };
+                    try 
+                    { 
+                        Class = uiaObject.GetCurrentPropertyValue(AutomationElement.ClassNameProperty) as string; 
+                    } 
+                    catch (Exception ex) 
+                    {
+                        Debug("Unable to resolve ClassName: " + ex.ToString());
+                        Class = msg; 
+                    };
+
                     var uiElement = new UIElement()
                     {
-                        ID = uiaObject.GetCurrentPropertyValue(AutomationElement.AutomationIdProperty) as string,
-                        Name = uiaObject.GetCurrentPropertyValue(AutomationElement.NameProperty) as string,
-                        Class = uiaObject.GetCurrentPropertyValue(AutomationElement.ClassNameProperty) as string,
+                        ID = ID,
+                        Name = Name,
+                        Class = Class,
                     };
                     uiElements.Add(uiElement);
                     var indent = "   ";
@@ -545,7 +579,7 @@ private bool MatchOnControlTree(List<UIElement> uiElements, string ctlParam)
 
 
         /// <summary>
-        /// used to cache and precompute regexes
+        /// used to cache and precompute regex's
         /// </summary>
         private static Dictionary<string, Regex> _regexes = new Dictionary<string, Regex>();
 
@@ -699,7 +733,7 @@ private string getExecutableFromHwnd(IntPtr hWnd)
         /// </summary>
         public override void Terminate()
         {
-            Debug("Keepass terminating");
+            Debug("KeePass terminating");
 
             AutoType.SequenceQuery -= AutoType_SequenceQuery;
             AutoType.SequenceQueriesBegin -= AutoType_SequenceQueriesBegin;

Disambiguator/Properties/AssemblyInfo.cs

@@ -7,7 +7,7 @@
 [assembly: AssemblyConfiguration("")]
 [assembly: AssemblyCompany("drventure")]
 [assembly: AssemblyProduct("KeePass Plugin")]
-[assembly: AssemblyCopyright("Copyright © 2023 drventure")]
+[assembly: AssemblyCopyright("Copyright © 2023-2024 drventure")]
 [assembly: AssemblyTrademark("")]
 [assembly: AssemblyCulture("")]
 
@@ -18,6 +18,6 @@
 [assembly: Guid("28241D0D-62D3-43A9-9355-B4016AA2F91E")]
 
 // Assembly version information
-[assembly: AssemblyVersion("1.0.5.0")]
+[assembly: AssemblyVersion("1.0.6.0")]
 
-[assembly: AssemblyFileVersion("1.0.5.0")]
+[assembly: AssemblyFileVersion("1.0.6.0")]

Readme.txt

@@ -166,6 +166,12 @@ Bugs can be reported using the issue tracker, for anything else, a wiki is avail
 
 
 Changelog
+--------
+v1.0.6.0
+Improved handling of failures when attempting to resolve control details via the MSAA layer.
+Even if the ID, Class, or Name can't be determined, if the other elements can, then we can still
+use the control for disambiguation.
+
 --------
 v1.0.5.0
 Corrected problem with CTL tag matching.

Releases/v1.0.6.0/Disambiguator-v1.0.6.0.zip

@@ -1,3 +1,3 @@
 :
-The Disambiguator:1.0.5
+The Disambiguator:1.0.6
 :