Merge pull request #12 from jmgarnier/add_reader_options

Add reader options

Author: nepalez

lib/dry/initializer/builder.rb

@@ -76,10 +76,19 @@ def copy(&block)
     end
 
     def define_readers(mixin)
-      readers = @signature.select { |item| item.settings[:reader] != false }
-                          .map(&:name)
+      define_reader(
+        mixin,
+        :attr_reader,
+        ->(item) { item.settings[:reader] != false }
+      )
+      define_reader mixin, :private
+      define_reader mixin, :protected
+    end
 
-      mixin.send :attr_reader, *readers if readers.any?
+    def define_reader(mixin, method, filter_lambda = nil)
+      filter_lambda ||= ->(item) { item.settings[:reader] == method }
+      readers = @signature.select(&filter_lambda).map(&:name)
+      mixin.send method, *readers if readers.any?
     end
 
     def reload_initializer(mixin)

spec/dry/reader_spec.rb

@@ -1,22 +1,87 @@
 describe "reader" do
-  subject do
-    class Test::Foo
-      extend Dry::Initializer::Mixin
+  shared_examples "it has no public attr_reader" do
+    it "does not define a public attr_reader" do
+      expect(subject).not_to respond_to :foo
+      expect(subject).not_to respond_to :bar
+    end
+  end
+
+  context "with reader: :public or no reader: option" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo
+        param  :foo2, reader: :public
+        option :bar
+        option :bar2, reader: :public
+      end
+
+      Test::Foo.new 1, 2, bar: 3, bar2: 4
+    end
 
-      param  :foo, reader: false
-      option :bar, reader: false
+    it "defines a public attr_reader by default" do
+      expect(subject).to respond_to(:foo, :foo2)
+      expect(subject).to respond_to :bar
+      expect(subject).to respond_to :bar2
     end
+  end
+
+  context "with reader: false" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: false
+        option :bar, reader: false
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it_behaves_like "it has no public attr_reader"
 
-    Test::Foo.new 1, bar: 2
+    it "keeps assigning variables" do
+      expect(subject.instance_variable_get(:@foo)).to eql 1
+      expect(subject.instance_variable_get(:@bar)).to eql 2
+    end
   end
 
-  it "skips attr_reader" do
-    expect(subject).not_to respond_to :foo
-    expect(subject).not_to respond_to :bar
+  context "with reader: :private" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: :private
+        option :bar, reader: :private
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it_behaves_like "it has no public attr_reader"
+
+    it "adds a private attr_reader" do
+      expect(subject.send(:foo)).to eql 1
+      expect(subject.send(:bar)).to eql 2
+    end
   end
 
-  it "keeps assigning variables" do
-    expect(subject.instance_variable_get(:@foo)).to eql 1
-    expect(subject.instance_variable_get(:@bar)).to eql 2
+  context "with reader: :protected" do
+    subject do
+      class Test::Foo
+        extend Dry::Initializer::Mixin
+
+        param  :foo, reader: :protected
+        option :bar, reader: :protected
+      end
+
+      Test::Foo.new 1, bar: 2
+    end
+
+    it "adds a protected attr_reader" do
+      protected_instance_methods = subject.class.protected_instance_methods
+      expect(protected_instance_methods).to match_array([:foo, :bar])
+    end
   end
 end