Skip to content

prettier conflicts with tslint #259

Open
@gomain

Description

@gomain

Running prettier via yarn format results in this diff in src/makePatch.ts
(Note: prettier needs to be run twice)

-    // copy .npmrc/.yarnrc in case packages are hosted in private registry
-    [".npmrc", ".yarnrc"].forEach(rcFile => {
+      // copy .npmrc/.yarnrc in case packages are hosted in private registry
+    ;[".npmrc", ".yarnrc"].forEach(rcFile => {

Comment is indented and a semi-colon is inserted before the tuple. This causes tslint to flag

ERROR: src/makePatch.ts:106:6 - statements are not aligned

After update prettier to 2.1.1 the comment indentation is fixed to

     // copy .npmrc/.yarnrc in case packages are hosted in private registry
-    [".npmrc", ".yarnrc"].forEach(rcFile => {
+    ;[".npmrc", ".yarnrc"].forEach((rcFile) => {

but the tslint error pertains. Updating tslint to 6.1.3 seems to fix it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions