Skip to content

Commit d47f9f1

Browse files
committed
fix: use regexp.escape polyfill package
1 parent dd1df98 commit d47f9f1

8 files changed

Lines changed: 662 additions & 18 deletions

File tree

lm-tests/analyzeBuildError.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import assert from "node:assert/strict";
22

3-
import escapeRegExp from "lodash.escaperegexp";
3+
import escapeRegExp from "regexp.escape";
44
import * as vscode from "vscode";
55

66
import {

lm-tests/analyzeSyncError.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import assert from "node:assert/strict";
22

3-
import escapeRegExp from "lodash.escaperegexp";
3+
import escapeRegExp from "regexp.escape";
44
import * as vscode from "vscode";
55

66
import { analyzeSyncError } from "../src/chat/commands/upgradesFindCL";

lm-tests/analyzeTestError.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import assert from "node:assert/strict";
22

3-
import escapeRegExp from "lodash.escaperegexp";
3+
import escapeRegExp from "regexp.escape";
44
import * as vscode from "vscode";
55

66
import {

lm-tests/searchChromiumLog.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import assert from "node:assert/strict";
22

3-
import escapeRegExp from "lodash.escaperegexp";
3+
import escapeRegExp from "regexp.escape";
44
import * as vscode from "vscode";
55

66
import {

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1106,14 +1106,14 @@
11061106
"@types/markdown-it-emoji": "^3.0.1",
11071107
"@types/mocha": "^10.0.9",
11081108
"@types/node": "^22.8.6",
1109+
"@types/regexp.escape": "^2.0.0",
11091110
"@types/uuid": "^10.0.0",
11101111
"@types/vscode": "1.96.0",
11111112
"esbuild": "^0.25.0",
11121113
"eslint": "^9.13.0",
11131114
"husky": "^9.1.6",
11141115
"json-schema-to-typescript": "^15.0.2",
11151116
"lint-staged": "^16.4.0",
1116-
"lodash.escaperegexp": "^4.1.2",
11171117
"mocha": "^11.1.0",
11181118
"npm-run-all2": "^7.0.2",
11191119
"prettier": "^3.3.3",
@@ -1132,6 +1132,7 @@
11321132
"markdown-it": "^14.1.0",
11331133
"markdown-it-emoji": "^3.0.0",
11341134
"nanoid": "^5.1.5",
1135+
"regexp.escape": "^2.0.1",
11351136
"typescript": "^4.5.5",
11361137
"typescript-cached-transpile": "^0.0.6",
11371138
"uuid": "^11.0.5",

src/tests.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import * as net from "node:net";
22
import * as os from "node:os";
33

44
import { ElectronVersions, SemVer } from "@electron/fiddle-core";
5+
import escapeRegExp from "regexp.escape";
56
import * as vscode from "vscode";
67

78
import { setupSpecRunner } from "../electron/spec-runner";
@@ -13,7 +14,7 @@ import {
1314
} from "./extensionState";
1415
import Logger from "./logging";
1516
import { runAsTask } from "./tasks";
16-
import { escapeStringForRegex, generateSocketName } from "./utils";
17+
import { generateSocketName } from "./utils";
1718

1819
interface ParsedTestData {
1920
title: string;
@@ -146,7 +147,7 @@ export async function createTestController(
146147
testsToAdd?.forEach((test) => {
147148
if (!request.exclude?.includes(test)) {
148149
addTests(test);
149-
testRegexes.push(escapeStringForRegex(test.id));
150+
testRegexes.push(escapeRegExp(test.id));
150151
} else {
151152
testsById.delete(test.id);
152153
}

src/utils.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -462,10 +462,6 @@ export function alphabetizeByLabel<T extends vscode.TreeItem>(
462462
});
463463
}
464464

465-
export function escapeStringForRegex(str: string) {
466-
return str.replace("(", "\\(").replace(")", "\\)").replace(".", "\\.");
467-
}
468-
469465
export function ensurePosixSeparators(filePath: string) {
470466
return filePath.split(path.sep).join(path.posix.sep);
471467
}

0 commit comments

Comments
 (0)