Fix for Issue with Local testing on systems with non en-us Culture (#285)

Author: ahpooch

CHANGELOG.md

@@ -57,6 +57,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - DSC_DnsServerClientSubnet
   - Fixed wrong SYNAPSIS.
 - Pester tests
+  - Fixed issue with local testing on systems with non en-US Culture in DSC_DnsServerRootHint
+    unit test. It fixes [[Issue #283](https://github.com/dsccommunity/DnsServerDsc/issues/283)].
   - Fixed a typo in stream suppression causing Error stream to be suppressed when
     it was supposed not to be ([issue #274](https://github.com/dsccommunity/DnsServerDsc/issues/274)).
   - Fixed Unit test for DSC_DnsRecordPtr DSC resource. -ErrorMassage changed to -ErrorId 'InvalidCastParseTargetInvocation'.

source/Classes/020.DnsRecordPtr.ps1

@@ -170,7 +170,7 @@ class DnsRecordPtr : DnsRecordBase
     }
 
     # Translate the IP address to the reverse notation used by the DNS server
-    hidden [System.String] getReverseNotation([System.Net.IpAddress] $ipAddressObj)
+    hidden [System.String] getReverseNotation([System.Net.IpAddress] $IPAddressObj)
     {
         $significantData = [System.Collections.ArrayList]::New()
 
@@ -197,8 +197,11 @@ class DnsRecordPtr : DnsRecordBase
     }
 
     # Determine the record host name
-    hidden [System.String] getRecordHostName([System.Net.IpAddress] $ipAddressObj)
+    hidden [System.String] getRecordHostName([System.String] $IPAddress)
     {
+        Assert-IPAddress -Address $IPAddress
+        $ipAddressObj = [System.Net.IpAddress] $IPAddress
+
         $reverseLookupAddressComponent = ''
 
         switch ($ipAddressObj.AddressFamily)

tests/Unit/Classes/DnsRecordPtr.Tests.ps1

@@ -103,6 +103,7 @@ Describe 'Testing DnsRecordPtr Get Method' -Tag 'Get', 'DnsRecord', 'DnsRecordPt
             Mock -CommandName Get-DnsServerResourceRecord -MockWith {
                 Write-Verbose -Message 'Mock Get-DnsServerResourceRecord Called' -Verbose
             }
+            Mock -CommandName Assert-IPAddress
         }
 
         It 'Should return the state as absent' {
@@ -114,7 +115,8 @@ Describe 'Testing DnsRecordPtr Get Method' -Tag 'Get', 'DnsRecord', 'DnsRecordPt
                 $currentState.Ensure | Should -Be 'Absent'
             }
 
-            Should -Invoke Get-DnsServerResourceRecord -Exactly -Times 1 -Scope It
+            Should -Invoke -CommandName Assert-IPAddress -Exactly -Times 1 -Scope It
+            Should -Invoke -CommandName Get-DnsServerResourceRecord -Exactly -Times 1 -Scope It
         }
 
         It 'Should return the same values as present in Key properties' {
@@ -127,6 +129,9 @@ Describe 'Testing DnsRecordPtr Get Method' -Tag 'Get', 'DnsRecord', 'DnsRecordPt
                 $getMethodResourceResult.IpAddress | Should -Be $script:instanceDesiredState.IpAddress
                 $getMethodResourceResult.Name | Should -Be $script:instanceDesiredState.Name
             }
+
+            Should -Invoke -CommandName Assert-IPAddress -Exactly -Times 1 -Scope It
+            Should -Invoke -CommandName Get-DnsServerResourceRecord -Exactly -Times 1 -Scope It
         }
 
         It 'Should return $false or $null respectively for the rest of the non-key properties' {
@@ -147,20 +152,21 @@ Describe 'Testing DnsRecordPtr Get Method' -Tag 'Get', 'DnsRecord', 'DnsRecordPt
 
             Mock -CommandName Get-DnsServerResourceRecord -MockWith {
                 Write-Verbose -Message 'Mock Get-DnsServerResourceRecord Called' -Verbose
-
                 return Import-Clixml -Path "$($mockInstancesPath)\..\MockObjects\PtrRecordInstance.xml"
             }
+            Mock -CommandName Assert-IPAddress
         }
 
         It 'Should return the state as present' {
             InModuleScope -ScriptBlock {
                 Set-StrictMode -Version 1.0
 
                 $currentState = $script:instanceDesiredState.Get()
-
-                Should -Invoke Get-DnsServerResourceRecord -Exactly -Times 1 -Scope It
                 $currentState.Ensure | Should -Be 'Present'
             }
+
+            Should -Invoke -CommandName Assert-IPAddress -Exactly -Times 1 -Scope It
+            Should -Invoke -CommandName Get-DnsServerResourceRecord -Exactly -Times 1 -Scope It
         }
 
         It 'Should return the same values as present in Key properties' {
@@ -172,6 +178,8 @@ Describe 'Testing DnsRecordPtr Get Method' -Tag 'Get', 'DnsRecord', 'DnsRecordPt
                 $getMethodResourceResult.IpAddress | Should -Be $script:instanceDesiredState.IpAddress
                 $getMethodResourceResult.Name | Should -Be $script:instanceDesiredState.Name
             }
+
+            Should -Invoke -CommandName Assert-IPAddress -Exactly -Times 1 -Scope It
         }
     }
 }
@@ -474,34 +482,6 @@ Describe 'Testing DnsRecordPtr Set Method' -Tag 'Set', 'DnsRecord', 'DnsRecordPt
 }
 
 Describe 'Test bad inputs (both IPv4 and IPv6)' -Tag 'Test', 'DnsRecord', 'DnsRecordPtr' {
-    It 'Throws when the IPv4 address is malformatted' {
-        InModuleScope -ScriptBlock {
-            Set-StrictMode -Version 1.0
-            $malformattedIPv4State = [DnsRecordPtr] @{
-                ZoneName  = '0.168.192.in-addr.arpa'
-                IpAddress = '192.168.0.DS9'
-                Name      = 'quarks.contoso.com'
-                Ensure    = 'Present'
-            }
-
-            { $malformattedIPv4State.Get() } | Should -Throw -ExpectedMessage ('*' + '"Cannot convert value "{0}" to type "System.Net.IPAddress". Error: "An invalid IP address was specified.""' -f $malformattedIPv4State.IpAddress)
-        }
-    }
-
-    It 'Throws when the IPv6 address is malformatted' {
-        InModuleScope -ScriptBlock {
-            Set-StrictMode -Version 1.0
-
-            $malformattedIPv6State = [DnsRecordPtr] @{
-                ZoneName  = '0.0.d.f.ip6.arpa'
-                IpAddress = 'fd00::1::9'
-                Name      = 'quarks.contoso.com'
-                Ensure    = 'Present'
-            }
-
-            { $malformattedIPv6State.Get() } | Should -Throw -ExpectedMessage ('*' + '"Cannot convert value "{0}" to type "System.Net.IPAddress". Error: "An invalid IP address was specified.""' -f $malformattedIPv6State.IpAddress)
-        }
-    }
 
     It 'Throws when placed in an incorrect IPv4 reverse lookup zone' {
         InModuleScope -ScriptBlock {