fix: address second round of Copilot review comments on opencloud-eu#45

- `Makefile`: pass `HOME=/tmp` + `npm_config_cache=/tmp/.npm` into the
  spec compile container so `npm ci` can write its cache/state when
  the host uid/gid doesn't match `/home/node` in `node:22-alpine`.
- `spec/common.models.tsp`: move `SearchParam` here from `groups.tsp`.
  It's a generic OData `$search` query parameter and was creating an
  unnecessary `users.tsp -> groups.tsp` dependency.
- `spec/permissions.routes.tsp`: fix the role-id path parameter in each
  `GetPermissionRoleDefinition` `@opExample` so it matches the role id
  in the corresponding response body. Also align the File Drop
  `allowedResourceActions` value (`upload/create`) with the list
  endpoint's example.
- `spec/tags.tsp`: make the request body required on `assignTags` and
  `unassignTags` (the body schemas require `resourceId` and `tags`, so
  a body-less call can't succeed). Update `TagsOk`'s doc from
  "No content" to "Success" since the status code is 200 with empty
  body.
- `spec/permissions.models.tsp`: typo `than can be used` ->
  `that can be used`.

Author: dschmidt

Makefile

@@ -33,7 +33,7 @@ help: ## Show this help
 spec: $(SPEC) ## Compile TypeSpec sources into api/openapi-spec/v1.0.yaml
 
 $(SPEC): $(SPEC_SOURCES)
-	$(DOCKER_RUN) $(NODE_IMAGE) sh scripts/compile-spec.sh
+	$(DOCKER_RUN) -e HOME=/tmp -e npm_config_cache=/tmp/.npm $(NODE_IMAGE) sh scripts/compile-spec.sh
 
 go: $(SPEC) ## Generate the Go client into build/clients/go
 	$(DOCKER_RUN) -e OUTPUT_DIR=build/clients/go $(call generator_image,go) sh scripts/generate-go.sh

spec/common.models.tsp

@@ -67,3 +67,10 @@ model TopParam {
   @minValue(0)
   `$top`?: integer;
 }
+
+@friendlyName("search")
+model SearchParam {
+  @query
+  @doc("Search items by search phrases")
+  `$search`?: string;
+}

spec/groups.tsp

@@ -42,13 +42,6 @@ model groupModel {
 // Shared query parameters / response shapes
 // =============================================================================
 
-@friendlyName("search")
-model SearchParam {
-  @query
-  @doc("Search items by search phrases")
-  `$search`?: string;
-}
-
 model GroupIdPath {
   @path
   @extension("x-ms-docs-key-type", "group")

spec/permissions.models.tsp

@@ -72,7 +72,7 @@ model unifiedRoleDefinition {
   `@libre.graph.weight`?: int32;
 }
 
-@doc("A list of permission roles than can be used when sharing with users or groups.")
+@doc("A list of permission roles that can be used when sharing with users or groups.")
 model RoleDefinitionsListed {
   @statusCode _: 200;
   @body body: unifiedRoleDefinition[];

spec/permissions.routes.tsp

@@ -120,7 +120,7 @@ namespace PermissionRoleDefinition {
   )
   @opExample(
     #{
-      parameters: #{`role-id`: "b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5"},
+      parameters: #{`role-id`: "fb6c3e19-e378-47e5-b277-9732f9de6e21"},
       returnType: #{
         _: 200,
         body: #{
@@ -141,7 +141,7 @@ namespace PermissionRoleDefinition {
   )
   @opExample(
     #{
-      parameters: #{`role-id`: "b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5"},
+      parameters: #{`role-id`: "312c0871-5ef7-4b3a-85b6-0e4074c64049"},
       returnType: #{
         _: 200,
         body: #{
@@ -162,7 +162,7 @@ namespace PermissionRoleDefinition {
   )
   @opExample(
     #{
-      parameters: #{`role-id`: "b1e2218d-eef8-4d4c-b82d-0f1a1b48f3b5"},
+      parameters: #{`role-id`: "4916f47e-66d5-49bb-9ac9-748ad00334b"},
       returnType: #{
         _: 200,
         body: #{
@@ -171,7 +171,7 @@ namespace PermissionRoleDefinition {
           displayName: "File Drop",
           rolePermissions: #[
             #{
-              allowedResourceActions: #["libre.graph/driveItem/standard/create"],
+              allowedResourceActions: #["libre.graph/driveItem/upload/create"],
               condition: "exists @Resource.File",
             },
           ],

spec/tags.tsp

@@ -26,7 +26,7 @@ model TagsRetrieved {
 
 alias tagsResponse = Collection<string, "CollectionOfTags">;
 
-@doc("No content")
+@doc("Success")
 model TagsOk {
   @statusCode _: 200;
 }
@@ -57,7 +57,7 @@ namespace Tags {
   @put
   op assignTags(
     @body
-    body?: tagAssignment,
+    body: tagAssignment,
   ): TagsOk | OdataError;
 
   @summary("Unassign tags from a resource")
@@ -77,6 +77,6 @@ namespace Tags {
   @delete
   op unassignTags(
     @body
-    body?: tagUnassignment,
+    body: tagUnassignment,
   ): TagsOk | OdataError;
 }